From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] vinyl: restart read iterator in case of rolled back WAL
Date: Sat, 20 Jun 2020 18:33:19 +0200 [thread overview]
Message-ID: <fbf08105-1bd3-2954-fb38-4008cabf73c3@tarantool.org> (raw)
In-Reply-To: <20200619123425.GB19725@tarantool.org>
>> Talking of the tests, I tried running multiple instances of the new
>> test:
>>
>> python test-run.py gh-3395-read-prepared-un gh-3395-read-prepared-un gh-3395-read-prepared-un gh-3395-read-prepared-un gh-3395-read-prepared-un gh-3395-read-prepared-un
>>
>> And it fails sometimes. So it is flaky. Better fix it before push.
>
> I've added a tiny fix:
>
> diff --git a/test/vinyl/gh-3395-read-prepared-uncommitted.test.lua b/test/vinyl/gh-3395-read-prepared-uncommitted.test.lua
> index 10b70dd85..70136ddff 100644
> --- a/test/vinyl/gh-3395-read-prepared-uncommitted.test.lua
> +++ b/test/vinyl/gh-3395-read-prepared-uncommitted.test.lua
> @@ -55,9 +55,7 @@ function read_prepared_with_delay(is_tx_faster_than_wal)
> errinj.set("ERRINJ_RELAY_FASTER_THAN_TX", true)
> end
> errinj.set("ERRINJ_WAL_DELAY", false)
> - if not is_tx_faster_than_wal then
> - fiber.sleep(0.1)
> - end
> + fiber.sleep(0.1)
> errinj.set("ERRINJ_VY_READ_PAGE_DELAY", false)
> local res = c:get()
> errinj.set("ERRINJ_WAL_WRITE", false)
>
>
> Could you please check if it still fails on your machine?
Now it works.
next prev parent reply other threads:[~2020-06-20 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 16:46 Nikita Pettik
2020-06-01 17:40 ` Vladislav Shpilevoy
2020-06-19 12:34 ` Nikita Pettik
2020-06-20 16:33 ` Vladislav Shpilevoy [this message]
2020-06-16 12:10 ` Aleksandr Lyapunov
2020-06-19 12:24 ` Nikita Pettik
2020-06-19 12:42 ` Konstantin Osipov
2020-06-23 5:15 ` Aleksandr Lyapunov
2020-06-23 11:08 ` Konstantin Osipov
2020-06-19 13:01 ` Aleksandr Lyapunov
2020-06-24 13:41 ` Nikita Pettik
2020-06-20 16:33 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbf08105-1bd3-2954-fb38-4008cabf73c3@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] vinyl: restart read iterator in case of rolled back WAL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox