Re: [Tarantool-patches] [PATCH] Add options for upgrade testing

[Sergey Bronnikov <sergeyb@tarantool.org>]

On 02.12.2020 06:40, Alexander Turenko wrote:

<snipped>
> I'm okay with the state on the branch [3] (it is updated as shown above)
> and I ready to push it if you don't have objections against the result
> of squashing. I included my variant of extract_schema_from_snapshot()
> (but it leans on PATH, it is enough for usages from TarantoolServer).

I have tested patches again and it seems it works as expected.

Let's merge patches to master.

>
> I performed the following tests using tarantool 2.7.0-73-gb53cb2aec
> repository (debug build).
>
> 0. make lint
>     No errors / warnings. Okay.
>
> 1. An app test.
>      | (cd test && ./test-run.py box-tap/merger.test.lua)
>     Passed. Okay.
>
> 2. An app test. Snapshot from 1.10.
>      | (cd test && ./test-run.py                              \
>      |     --snapshot ../../../1.10/00000000000000000000.snap \
>      |     box-tap/merger.test.lua)
>     Passed. Upgrade entries are present in the log. Okay.
>
> 3. An app test. Snapshot from 1.10. No schema upgrade.
>      | (cd test && ./test-run.py                              \
>      |     --snapshot ../../../1.10/00000000000000000000.snap \
>      |     box-tap/merger.test.lua --disable-schema-upgrade)
>     Passed. No upgrade entries in the log. Okay.
>
> 4. A tarantool test.
>      | (cd test && ./test-run.py box/net.box_timeout_gh-1533.test.lua)
>     Passed. Okay.
>
> 5. A tarantool test. Snapshot from 1.10.
>      | (cd test && ./test-run.py                              \
>      |     --snapshot ../../../1.10/00000000000000000000.snap \
>      |     box/net.box_timeout_gh-1533.test.lua)
>     Passed. Upgrade entries are present in the log. Okay.
>
> 6. A tarantool test. Snapshot from 1.10. No schema upgrade.
>      | (cd test && ./test-run.py                              \
>      |     --snapshot ../../../1.10/00000000000000000000.snap \
>      |     box/net.box_timeout_gh-1533.test.lua --disable-schema-upgrade)
>     Passed. No upgrade entries in the log. Okay.
>
> 7. --disable-schema-upgrade without --snapshot.
>      | (cd test && ./test-run.py --disable-schema-upgrade)
>     Gives an error. Okay.
>
> 8. Conflicting options.
>      | (cd test && ./test-run.py --gdb --valgrind)
>     Gives an error. Okay.
>
> 9. Run the whole test suite.
>      | (cd test && ./test-run.py --long --force)
>     Passed except replication/election_qsync_stress.test.lua, which is
>     known as flaky on this revision. Okay.
>
> Rebuilt the same tarantool revision as RelWithDebInfo and performed the
> following test:
>
> 10. Attempt to use --disable-schema-upgrade on a RelWithDebInfo build.
>       | (cd test && ./test-run.py                              \
>       |     --snapshot ../../../1.10/00000000000000000000.snap \
>       |     box/net.box_timeout_gh-1533.test.lua --disable-schema-upgrade)
>      Gives an error. Okay.
>
> I rewrote my 'snapshot mangling' patches to introduce the new
> --bootstrap option and pushed them to the branch [4]. I propose to don't
> push them to master at least until we'll found them useful.
>
> [1]: https://github.com/tarantool/tarantool/issues/5540
> [2]: https://github.com/tarantool/tarantool/issues/4801
> [3]: ligurio/gh-4801-add-snapshot-option
> [4]: Totktonada/gh-4801-add-bootstrap-option