From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Alexander Turenko <alexander.turenko@tarantool.org> Cc: Sergey Bronnikov <estetus@gmail.com>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v1 2/4] test: fix xlog-py/big_lsn.test.py Date: Thu, 14 Jan 2021 15:52:46 +0300 [thread overview] Message-ID: <faf6be57-ab03-1253-a6ca-f51e2bd2fc26@tarantool.org> (raw) In-Reply-To: <20210114123843.lszgppsskx734xjl@tkn_work_nb> Thanks for review! On 14.01.2021 15:38, Alexander Turenko wrote: >> @@ -17,7 +18,7 @@ new_lsn = 123456789123 >> wal_dir = os.path.join(server.vardir, server.name) >> old_wal = os.path.join(wal_dir, "%020d.xlog" % old_lsn) >> new_wal = os.path.join(wal_dir, "%020d.xlog" % new_lsn) >> -with open(old_wal, "r+") as f: >> +with codecs.open(old_wal, "r+", encoding = "ISO-8859-1") as f: > Nit: PEP-8 requires func(foo='bar') -- without surrounding whitespaces. Agree. Fixed in a branch. > > I would read the binary file using 'rb+' (to bytes) and convert strings, > which are known to be correct utf-8/ascii to Python strings (unicode) > manually, but your solution should work too (and requires less code). > > I was afraid that f.read() will see some bytes that're undefined in the > ISO-8859-1 encoding and it'll lead to an exception like it does for > UTF-8. But no, it just returns u'\x00' or kinda. > > Okay so.
next prev parent reply other threads:[~2021-01-14 12:52 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-13 8:48 [Tarantool-patches] [PATCH v1 0/4] Support Python 3 in Tarantool tests Sergey Bronnikov via Tarantool-patches 2021-01-13 8:48 ` [Tarantool-patches] [PATCH v1 1/4] test: fix app-tap/http_client.test.lua Sergey Bronnikov via Tarantool-patches 2021-01-14 8:47 ` Leonid Vasiliev via Tarantool-patches 2021-01-14 9:50 ` Sergey Bronnikov via Tarantool-patches 2021-01-14 12:23 ` Alexander Turenko via Tarantool-patches 2021-01-14 12:52 ` Sergey Bronnikov via Tarantool-patches 2021-01-14 12:57 ` Alexander Turenko via Tarantool-patches 2021-01-13 8:48 ` [Tarantool-patches] [PATCH v1 2/4] test: fix xlog-py/big_lsn.test.py Sergey Bronnikov via Tarantool-patches 2021-01-14 9:02 ` Leonid Vasiliev via Tarantool-patches 2021-01-14 9:51 ` Sergey Bronnikov via Tarantool-patches 2021-01-14 12:38 ` Alexander Turenko via Tarantool-patches 2021-01-14 12:52 ` Sergey Bronnikov via Tarantool-patches [this message] 2021-01-13 8:48 ` [Tarantool-patches] [PATCH v1 3/4] test: enable SO_REUSEADDR on socket in httpd.py Sergey Bronnikov via Tarantool-patches 2021-01-13 19:59 ` Cyrill Gorcunov via Tarantool-patches 2021-01-14 9:09 ` Leonid Vasiliev via Tarantool-patches 2021-01-14 9:57 ` Sergey Bronnikov via Tarantool-patches 2021-01-14 12:51 ` Alexander Turenko via Tarantool-patches 2021-01-13 8:48 ` [Tarantool-patches] [PATCH v1 4/4] test: enable disabled testcases back Sergey Bronnikov via Tarantool-patches 2021-01-14 9:10 ` Leonid Vasiliev via Tarantool-patches 2021-01-13 20:03 ` [Tarantool-patches] [PATCH v1 0/4] Support Python 3 in Tarantool tests Cyrill Gorcunov via Tarantool-patches 2021-01-14 11:10 ` Leonid Vasiliev via Tarantool-patches 2021-01-15 9:34 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=faf6be57-ab03-1253-a6ca-f51e2bd2fc26@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=estetus@gmail.com \ --cc=sergeyb@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1 2/4] test: fix xlog-py/big_lsn.test.py' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox