Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tarantool-patches@dev.tarantool.org, lvasiliev@tarantool.org
Cc: alexander.turenko@tarantool.org
Subject: [Tarantool-patches] [PATCH v1 4/4] test: enable disabled testcases back
Date: Wed, 13 Jan 2021 11:48:36 +0300	[thread overview]
Message-ID: <c351b68479a0fd71f4ba8d504ac3254e56bfaeb9.1610526975.git.estetus@gmail.com> (raw)
In-Reply-To: <cover.1610526975.git.estetus@gmail.com>

From: Sergey Bronnikov <sergeyb@tarantool.org>

In a commit "httpc: temporary disable redirecting test case"
(4cc6978ae7be7dc3785a52c064b07850582522de) a set of testcases
has been disabled while the bug #4180 is open.
Right now bug is closed so it is a time to enable testcases back.
---
 test/app-tap/http_client.test.lua | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/test/app-tap/http_client.test.lua b/test/app-tap/http_client.test.lua
index 093af8fe4..aafad0004 100755
--- a/test/app-tap/http_client.test.lua
+++ b/test/app-tap/http_client.test.lua
@@ -62,7 +62,7 @@ local function stop_server(test, server)
 end
 
 local function test_http_client(test, url, opts)
-    test:plan(11)
+    test:plan(12)
 
     -- gh-4136: confusing httpc usage error message
     local ok, err = pcall(client.request, client)
@@ -85,9 +85,6 @@ local function test_http_client(test, url, opts)
     local r = client.request('GET', url, nil, opts)
     test:is(r.status, 200, 'request')
 
-    -- XXX: enable after resolving of gh-4180: httpc: redirects
-    -- are broken with libcurl-7.30 and older
-    --[[
     -- gh-4119: specify whether to follow 'Location' header
     test:test('gh-4119: follow location', function(test)
         test:plan(7)
@@ -111,7 +108,6 @@ local function test_http_client(test, url, opts)
         test:is(r.body, 'redirecting', 'do not follow location: body')
         test:is(r.headers['location'], '/', 'do not follow location: header')
     end)
-    ]]--
 end
 
 --
-- 
2.25.1


  parent reply	other threads:[~2021-01-13  8:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13  8:48 [Tarantool-patches] [PATCH v1 0/4] Support Python 3 in Tarantool tests Sergey Bronnikov via Tarantool-patches
2021-01-13  8:48 ` [Tarantool-patches] [PATCH v1 1/4] test: fix app-tap/http_client.test.lua Sergey Bronnikov via Tarantool-patches
2021-01-14  8:47   ` Leonid Vasiliev via Tarantool-patches
2021-01-14  9:50     ` Sergey Bronnikov via Tarantool-patches
2021-01-14 12:23   ` Alexander Turenko via Tarantool-patches
2021-01-14 12:52     ` Sergey Bronnikov via Tarantool-patches
2021-01-14 12:57       ` Alexander Turenko via Tarantool-patches
2021-01-13  8:48 ` [Tarantool-patches] [PATCH v1 2/4] test: fix xlog-py/big_lsn.test.py Sergey Bronnikov via Tarantool-patches
2021-01-14  9:02   ` Leonid Vasiliev via Tarantool-patches
2021-01-14  9:51     ` Sergey Bronnikov via Tarantool-patches
2021-01-14 12:38   ` Alexander Turenko via Tarantool-patches
2021-01-14 12:52     ` Sergey Bronnikov via Tarantool-patches
2021-01-13  8:48 ` [Tarantool-patches] [PATCH v1 3/4] test: enable SO_REUSEADDR on socket in httpd.py Sergey Bronnikov via Tarantool-patches
2021-01-13 19:59   ` Cyrill Gorcunov via Tarantool-patches
2021-01-14  9:09   ` Leonid Vasiliev via Tarantool-patches
2021-01-14  9:57     ` Sergey Bronnikov via Tarantool-patches
2021-01-14 12:51       ` Alexander Turenko via Tarantool-patches
2021-01-13  8:48 ` Sergey Bronnikov via Tarantool-patches [this message]
2021-01-14  9:10   ` [Tarantool-patches] [PATCH v1 4/4] test: enable disabled testcases back Leonid Vasiliev via Tarantool-patches
2021-01-13 20:03 ` [Tarantool-patches] [PATCH v1 0/4] Support Python 3 in Tarantool tests Cyrill Gorcunov via Tarantool-patches
2021-01-14 11:10 ` Leonid Vasiliev via Tarantool-patches
2021-01-15  9:34 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c351b68479a0fd71f4ba8d504ac3254e56bfaeb9.1610526975.git.estetus@gmail.com \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=lvasiliev@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 4/4] test: enable disabled testcases back' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox