Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH] error: Add __concat method to error object

[Oleg Babin <olegrok@tarantool.org>]

Hello, thank you for review!


I will add test in second version of patch.

> Hello,
>
> On 22 окт 16:14, Kirill Yukhin wrote:
> Why do you prohibit rhs to be nil. If needed, should we also disable
> box.NULL?
>

We expect that error will have behavior as usual string then we should
prohibit

using of nils and box.NULLs:


```


tarantool> 'simple string' .. nil
---
- error: '[string "return ''simple string'' .. nil"]:1: attempt to
concatenate a nil
    value'
...

tarantool> 'simple string' .. box.NULL
---
- error: '[string "return ''simple string'' .. box.NULL"]:1: attempt to
concatenate
    ''string'' and ''void *'''
...


```

In this case "attempt to concatenate struct error and nil" will be returned


On 24/10/2019 09:21, Kirill Yukhin wrote:
> Hello,
>
> On 22 окт 16:14, Kirill Yukhin wrote:
>> From: Oleg Babin <babinoleg@mail.ru>
>>
>> Usually functions return pair {nil, err} and expected that err is string.
>> Let's make the behaviour of error object closer to string
>> and define __concat metamethod.
>>
>> Closes tarantool/tarantool#4489
>> ---
>>  src/lua/error.lua | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/src/lua/error.lua b/src/lua/error.lua
>> index 28fc0377d..b44fab7b6 100644
>> --- a/src/lua/error.lua
>> +++ b/src/lua/error.lua
>> @@ -150,9 +150,17 @@ local function error_index(err, key)
>>      return error_methods[key]
>>  end
>>  
>> +local function error_concat(lhs, rhs)
>> +    if lhs == nil or rhs == nil then
>> +        error("attempt to concatenate struct error and nil")
>> +    end
> Why do you prohibit rhs to be nil. If needed, should we also disable
> box.NULL?
>
> Why you didn't add a test?
>
> --
> Regards, Kirill Yukhin
>
--

Oleg Babin