From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 4/5] temporary: disable boolean.test.sql
Date: Sat, 26 Oct 2019 19:35:37 +0200 [thread overview]
Message-ID: <fa5671d0-7f93-5296-a619-731ba35a1bf7@tarantool.org> (raw)
In-Reply-To: <74ad080dfda5faf647366f8c358603432c4284b4.1572014706.git.imeevma@gmail.com>
Thanks for the patch!
On 25/10/2019 17:45, imeevma@tarantool.org wrote:
> Since PRAGMA 'sql_default_engine' will be removed in the next
> patch, this test will fail until test-run is fixed.
>
> This patch should be removed before patch-set will be pushed.
Not sure if I understand. Does the next patch break this
test? If so, why does not it fix the test?
> ---
> test/sql/suite.ini | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/sql/suite.ini b/test/sql/suite.ini
> index a8664c5..a2573be 100644
> --- a/test/sql/suite.ini
> +++ b/test/sql/suite.ini
> @@ -8,7 +8,7 @@ config = engine.cfg
> is_parallel = True
> lua_libs = lua/sql_tokenizer.lua
> release_disabled = errinj.test.lua view_delayed_wal.test.lua sql-debug.test.lua
> -disabled = sql-statN-index-drop.test.lua
> +disabled = sql-statN-index-drop.test.lua boolean.test.sql
> pretest_clean = True
> fragile = dll.test.lua ; gh-4427
> func-recreate.test.lua ; gh-4384
>
next prev parent reply other threads:[~2019-10-26 17:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 15:45 [Tarantool-patches] [PATCH v2 0/5] Replace control pragmas by SET imeevma
2019-10-25 15:45 ` [Tarantool-patches] [PATCH v2 1/5] sysview: make get() and create_iterator() methods virtual imeevma
2019-10-25 15:45 ` [Tarantool-patches] [PATCH v2 2/5] box: introdice _vsession_settings sysview imeevma
2019-10-26 17:35 ` Vladislav Shpilevoy
2019-10-31 11:26 ` [Tarantool-patches] [tarantool-patches] " Mergen Imeev
2019-11-02 16:17 ` Vladislav Shpilevoy
2019-10-25 15:45 ` [Tarantool-patches] [PATCH v2 3/5] sql: introduce SET statement imeevma
2019-10-25 15:45 ` [Tarantool-patches] [PATCH v2 4/5] temporary: disable boolean.test.sql imeevma
2019-10-26 17:35 ` Vladislav Shpilevoy [this message]
2019-10-27 10:45 ` Mergen Imeev
2019-10-25 15:45 ` [Tarantool-patches] [PATCH v2 5/5] sql: replace control pragmas imeevma
2019-10-26 17:34 ` [Tarantool-patches] [PATCH v2 0/5] Replace control pragmas by SET Vladislav Shpilevoy
2019-10-27 10:29 ` [Tarantool-patches] [tarantool-patches] " Mergen Imeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa5671d0-7f93-5296-a619-731ba35a1bf7@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [PATCH v2 4/5] temporary: disable boolean.test.sql' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox