Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Oleg Babin <olegrok@tarantool.org>, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH vshard 2/2] Drop periodic Lua GC explicit call
Date: Fri, 28 Jan 2022 23:19:33 +0100	[thread overview]
Message-ID: <f9587f83-5b13-6451-3a16-ea8d179e00e0@tarantool.org> (raw)
In-Reply-To: <bcf56f47-bb7a-805b-eb4f-5f3c8cb1a35c@tarantool.org>

Hi! Thanks for the review and for noticing the issue!

On 28.01.2022 06:47, Oleg Babin wrote:
> Thanks for your patch.
> 
> Consider also following diff
> 
> diff --git a/vshard/CMakeLists.txt b/vshard/CMakeLists.txt
> index 2a15df5..2d9be25 100644
> --- a/vshard/CMakeLists.txt
> +++ b/vshard/CMakeLists.txt
> @@ -7,5 +7,5 @@ add_subdirectory(router)
> 
>  # Install module
>  install(FILES cfg.lua error.lua consts.lua hash.lua init.lua replicaset.lua
> -        util.lua lua_gc.lua rlist.lua heap.lua registry.lua
> +        util.lua rlist.lua heap.lua registry.lua
>          DESTINATION ${TARANTOOL_INSTALL_LUADIR}/vshard)
> 
> 
> After it LGTM.

Done and pushed to master.

      reply	other threads:[~2022-01-28 22:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28  0:23 [Tarantool-patches] [PATCH vshard 0/2] Deprecations Vladislav Shpilevoy via Tarantool-patches
2022-01-28  0:23 ` [Tarantool-patches] [PATCH vshard 1/2] Drop Tarantool < 1.10.1 support Vladislav Shpilevoy via Tarantool-patches
2022-01-28  5:47   ` Oleg Babin via Tarantool-patches
2022-01-28  0:23 ` [Tarantool-patches] [PATCH vshard 2/2] Drop periodic Lua GC explicit call Vladislav Shpilevoy via Tarantool-patches
2022-01-28  5:47   ` Oleg Babin via Tarantool-patches
2022-01-28 22:19     ` Vladislav Shpilevoy via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9587f83-5b13-6451-3a16-ea8d179e00e0@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=olegrok@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH vshard 2/2] Drop periodic Lua GC explicit call' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox