From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 27F6C6F873; Sat, 29 Jan 2022 01:19:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 27F6C6F873 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1643408377; bh=JYFKfDTm42kzNWVR8uN6/1aJHfF9KGQGnOsh9YOD5pg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=O0kFzpvCGcY2NsneqyX6ZH0AFG116KGRt/toORnKIZyuY/SJS5tQobouXyWctYnMI aO5cOoxLivB/mylBjNarnszcItc5sNATcoCpnB94bfEeb8JBm0CsjXBDOZLUX5oqQB +69OvMZpr6sGmabU1FckyzwgETgue1N8mfHhWPx4= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 635D06F873 for ; Sat, 29 Jan 2022 01:19:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 635D06F873 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1nDZag-0002XE-NM; Sat, 29 Jan 2022 01:19:35 +0300 Message-ID: Date: Fri, 28 Jan 2022 23:19:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Content-Language: en-US To: Oleg Babin , tarantool-patches@dev.tarantool.org References: <8017c8b948a682b62c4d722879fb1a1b1b85f936.1643329358.git.v.shpilevoy@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD99F281FB7F96F126DB121740E736B5D0E67545C63B0F815C500894C459B0CD1B91110231688F18D08DE52C0877E0A71E6C081C2D9F3DB95484DBA99B244D762C7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70A10A23A3B64B805EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063729381D024F10DD158638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EB534EA6FBB3A0991CE6FC38421ACE48117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6300D3B61E77C8D3B089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5EC5A58FE1AFEE1A5EF88561E9933D7168FC00A3461D52D1CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34023CA4E4726A7D6C4BDB4C2FB219B0E3F93D80468821048334DDB85772425EEDA15996190495B2471D7E09C32AA3244CA81AC81E10D985B67D01D2AD715C73DC853296C06374E602729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3WWIHBKIeBF5WW/nS9jPIQ== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D6735D63A068668E32A48E79A10E4049E23841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E25FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 2/2] Drop periodic Lua GC explicit call X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review and for noticing the issue! On 28.01.2022 06:47, Oleg Babin wrote: > Thanks for your patch. > > Consider also following diff > > diff --git a/vshard/CMakeLists.txt b/vshard/CMakeLists.txt > index 2a15df5..2d9be25 100644 > --- a/vshard/CMakeLists.txt > +++ b/vshard/CMakeLists.txt > @@ -7,5 +7,5 @@ add_subdirectory(router) > >  # Install module >  install(FILES cfg.lua error.lua consts.lua hash.lua init.lua replicaset.lua > -        util.lua lua_gc.lua rlist.lua heap.lua registry.lua > +        util.lua rlist.lua heap.lua registry.lua >          DESTINATION ${TARANTOOL_INSTALL_LUADIR}/vshard) > > > After it LGTM. Done and pushed to master.