From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>,
tarantool-patches@freelists.org,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: remove unused mask
Date: Wed, 14 Aug 2019 22:48:57 +0200 [thread overview]
Message-ID: <f92e8b3b-56f8-d56f-bd5a-7b9aa0ce559f@tarantool.org> (raw)
In-Reply-To: <EF5D0F6E-4C6C-458D-9650-2AA2262A6333@tarantool.org>
LGTM.
On 14/08/2019 16:35, Roman Khabibov wrote:
> Vlad, could you do a second review?
>
>> On Aug 9, 2019, at 18:46, n.pettik <korablev@tarantool.org> wrote:
>>
>>
>>
>>> On 2 Aug 2019, at 15:46, Roman Khabibov <roman.habibov@tarantool.org> wrote:
>>>
>>> Field mask of "struct Keyword" is always set to one not null
>>> macroses and used only once for checking that it isn't null. So,
>>> the field should be removed.
>>>
>>> Closes #4155
>>
>> I’ve fixed commit message and force pushed.
>>
>> sql: remove mask from struct Keyword
>>
>> Originally, mask in struct Keyword served to reduce set of reserved
>> keywords for build-dependent features. For instance, it was allowed to
>> disable triggers as a compilation option, and in this case TRIGGER
>> wouldn't be reserved word. Nowadays, our build always comprises all
>> features, so there's no need in this option anymore. Hence, we can
>> remove mask alongside with related to it macros.
>>
>> Closes #4155
>>
>> The rest is OK as obvious.
prev parent reply other threads:[~2019-08-14 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 12:46 [tarantool-patches] " Roman Khabibov
2019-08-09 15:46 ` [tarantool-patches] " n.pettik
2019-08-14 14:35 ` Roman Khabibov
2019-08-14 20:48 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f92e8b3b-56f8-d56f-bd5a-7b9aa0ce559f@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: remove unused mask' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox