From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 luajit] Fix command-line argv handling.
Date: Tue, 28 Jan 2025 12:03:08 +0300 [thread overview]
Message-ID: <f86df1c5-b9ff-4fb6-b5e4-95ea9cf0af3b@tarantool.org> (raw)
In-Reply-To: <20250127101814.23617-1-skaplun@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
Sergey,
thanks for the patch! LGTM with a minor comment.
Sergey
On 27.01.2025 13:18, Sergey Kaplun wrote:
<snipped>
> diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt
> index c4a402d0..c84c651d 100644
> --- a/test/tarantool-c-tests/CMakeLists.txt
> +++ b/test/tarantool-c-tests/CMakeLists.txt
> @@ -41,6 +41,14 @@ file(GLOB tests "${CMAKE_CURRENT_SOURCE_DIR}/*${CTEST_SRC_SUFFIX}")
> foreach(test_source ${tests})
> # Get test name without suffix. Needed to set OUTPUT_NAME.
> get_filename_component(exe ${test_source} NAME_WE)
> +
> + # Test requires static build, since it inspects internal
> + # symbols.
> + if(exe STREQUAL "gh-8594-sysprof-ffunc-crash"
> + AND BUILDMODE STREQUAL "dynamic")
please put AND to the previous line and fix indentation
<snipped>
[-- Attachment #2: Type: text/html, Size: 1530 bytes --]
next prev parent reply other threads:[~2025-01-28 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 10:18 Sergey Kaplun via Tarantool-patches
2025-01-28 9:03 ` Sergey Bronnikov via Tarantool-patches [this message]
2025-01-28 9:36 ` Sergey Kaplun via Tarantool-patches
2025-01-31 9:31 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f86df1c5-b9ff-4fb6-b5e4-95ea9cf0af3b@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 luajit] Fix command-line argv handling.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox