From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: Konstantin Osipov <kostja@tarantool.org> Cc: tarantool-patches@freelists.org Subject: [tarantool-patches] Re: [PATCH v2 4/4] Extract 'coll' library from 'core' Date: Tue, 26 Feb 2019 16:09:50 +0300 [thread overview] Message-ID: <f8250c43-44e9-182b-70ef-a4b760756247@tarantool.org> (raw) In-Reply-To: <20190226125525.GG5592@chai> On 26/02/2019 15:55, Konstantin Osipov wrote: > * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/02/26 15:42]: > >> We usually do not put such dependency links in any >> library headers. A programmer can look at CMakeLists, >> if he needs to know them. Secondly, it complicates update - >> when we added or removed a dependency, we would have >> had to update two files - source and CMakeLists.txt. >> Thirdly, even if you added as a dependency a static library, >> but did not add its own dependencies, it is ok - cmake >> handles that. > > OK, but a library is a standalone thing and it does need a README > file - describing its purpose, scope, dependencies, limitations. > > Don't you think so? > Usually we either do not write readme at all, or write it in the main header, describing the main functionality. And it is never about build details, dependencies, and limitations. All limitations are usually described with corresponding enum values and function comments. > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >
next prev parent reply other threads:[~2019-02-26 13:09 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-26 12:11 [tarantool-patches] [PATCH v2 0/4] Move 'core' lib to src/lib Vladislav Shpilevoy 2019-02-26 12:11 ` [tarantool-patches] [PATCH v2 1/4] Remove dead dependency of http_parser on httpc Vladislav Shpilevoy 2019-02-26 12:12 ` [tarantool-patches] " Vladislav Shpilevoy 2019-02-26 12:21 ` Konstantin Osipov 2019-02-26 12:11 ` [tarantool-patches] [PATCH v2 2/4] Move 'http_parser' to src/lib Vladislav Shpilevoy 2019-02-26 12:21 ` [tarantool-patches] " Konstantin Osipov 2019-02-26 16:57 ` Vladislav Shpilevoy 2019-02-26 12:11 ` [tarantool-patches] [PATCH v2 3/4] Move 'core' and 'uuid' libs " Vladislav Shpilevoy 2019-02-26 12:22 ` [tarantool-patches] " Konstantin Osipov 2019-02-26 16:57 ` Vladislav Shpilevoy 2019-02-26 12:11 ` [tarantool-patches] [PATCH v2 4/4] Extract 'coll' library from 'core' Vladislav Shpilevoy 2019-02-26 12:23 ` [tarantool-patches] " Konstantin Osipov 2019-02-26 12:37 ` Vladislav Shpilevoy 2019-02-26 12:55 ` Konstantin Osipov 2019-02-26 13:09 ` Vladislav Shpilevoy [this message] 2019-02-26 13:17 ` Konstantin Osipov 2019-02-26 13:43 ` Vladislav Shpilevoy 2019-02-27 15:07 ` Vladislav Shpilevoy 2019-02-26 16:55 ` [tarantool-patches] [PATCH 1/1] Move 'info' library to src/lib Vladislav Shpilevoy 2019-02-26 22:08 ` [tarantool-patches] " Konstantin Osipov 2019-02-27 15:07 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f8250c43-44e9-182b-70ef-a4b760756247@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v2 4/4] Extract '\''coll'\'' library from '\''core'\''' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox