From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 3/3] sql: dissallow bindings for DDL
Date: Thu, 13 Sep 2018 09:13:11 +0300 [thread overview]
Message-ID: <f7df5f44-01d0-7e24-4f80-ba9079ad7211@tarantool.org> (raw)
In-Reply-To: <119B9157-8352-4256-8160-427752400D3E@tarantool.org>
> -
> -
>
> Noise diff.
Ok.
> You forgot to drop table t5.
It isn't required as this attempt to create t5 should fail that is a test scenario.
> box.sql.execute("DROP TABLE t;")
> +
> +
>
> One new line is redundant.
Ok.
>
> The rest *obviously* LGTM.
Kirill, let's merge It.
next prev parent reply other threads:[~2018-09-13 6:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 15:45 [tarantool-patches] [PATCH v1 0/3] " Kirill Shcherbatov
2018-08-31 15:45 ` [tarantool-patches] [PATCH v1 1/3] sql: fix sql_check_list_item_init double free Kirill Shcherbatov
2018-08-31 15:45 ` [tarantool-patches] [PATCH v1 2/3] sql: fix sql_*_compile functions leak on error Kirill Shcherbatov
2018-08-31 15:45 ` [tarantool-patches] [PATCH v1 3/3] sql: dissallow bindings for DDL Kirill Shcherbatov
2018-09-04 11:00 ` [tarantool-patches] " n.pettik
2018-09-06 13:04 ` Kirill Shcherbatov
2018-09-10 21:52 ` n.pettik
2018-09-11 7:21 ` Kirill Shcherbatov
2018-09-11 23:03 ` n.pettik
2018-09-13 6:13 ` Kirill Shcherbatov [this message]
2018-09-13 10:12 ` [tarantool-patches] Re: [PATCH v1 0/3] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7df5f44-01d0-7e24-4f80-ba9079ad7211@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 3/3] sql: dissallow bindings for DDL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox