From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v10 0/4] box/cbox: implement cfunc Lua module
Date: Thu, 12 Nov 2020 23:53:35 +0100 [thread overview]
Message-ID: <f79fcb24-6d67-ab2d-7eed-e0a8f4e8f9cd@tarantool.org> (raw)
In-Reply-To: <20201105151808.456573-1-gorcunov@gmail.com>
Hi! Thanks for the patchset!
I am going to ask you to send responses to my comments in a
format of diff hunks fixing the comments. Usually you rush to
answer to my comments the same day they are sent with some
promises like "I will take a look", "I will see what can be done",
etc. But then you send a new version of the patchset without
responding to my comments with what you actually did regarding
each of them.
That makes me go through the comments on my own and look for the
commented places in the new patch to see the difference. It takes
significant time.
https://github.com/tarantool/tarantool/wiki/Code-review-procedure#during-the-review
Point 1.
next prev parent reply other threads:[~2020-11-12 22:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:18 Cyrill Gorcunov
2020-11-05 15:18 ` [Tarantool-patches] [PATCH v10 1/4] box/func: factor out c function entry structure Cyrill Gorcunov
2020-11-12 22:53 ` Vladislav Shpilevoy
2020-11-13 17:56 ` Cyrill Gorcunov
2020-11-05 15:18 ` [Tarantool-patches] [PATCH v10 2/4] module_cache: move module handling into own subsystem Cyrill Gorcunov
2020-11-12 22:54 ` Vladislav Shpilevoy
2020-11-16 9:54 ` Cyrill Gorcunov
2020-11-16 14:41 ` Cyrill Gorcunov
2020-11-05 15:18 ` [Tarantool-patches] [PATCH v10 3/4] box/cbox: implement cbox Lua module Cyrill Gorcunov
2020-11-12 22:53 ` Vladislav Shpilevoy
2020-11-16 20:26 ` Cyrill Gorcunov
2020-11-05 15:18 ` [Tarantool-patches] [PATCH v10 4/4] test: box/cfunc -- add simple module test Cyrill Gorcunov
2020-11-12 22:53 ` Vladislav Shpilevoy [this message]
2020-11-13 17:54 ` [Tarantool-patches] [PATCH v10 0/4] box/cbox: implement cfunc Lua module Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f79fcb24-6d67-ab2d-7eed-e0a8f4e8f9cd@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v10 0/4] box/cbox: implement cfunc Lua module' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox