From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DAB5B469719 for ; Fri, 13 Nov 2020 01:53:36 +0300 (MSK) References: <20201105151808.456573-1-gorcunov@gmail.com> From: Vladislav Shpilevoy Message-ID: Date: Thu, 12 Nov 2020 23:53:35 +0100 MIME-Version: 1.0 In-Reply-To: <20201105151808.456573-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v10 0/4] box/cbox: implement cfunc Lua module List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov , tml Hi! Thanks for the patchset! I am going to ask you to send responses to my comments in a format of diff hunks fixing the comments. Usually you rush to answer to my comments the same day they are sent with some promises like "I will take a look", "I will see what can be done", etc. But then you send a new version of the patchset without responding to my comments with what you actually did regarding each of them. That makes me go through the comments on my own and look for the commented places in the new patch to see the difference. It takes significant time. https://github.com/tarantool/tarantool/wiki/Code-review-procedure#during-the-review Point 1.