From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/1] test: drop invalid assert from swim test transport
Date: Tue, 30 Apr 2019 02:27:44 +0300 [thread overview]
Message-ID: <f79cd42d-fca3-6dd9-9807-9b49ea9ab61d@tarantool.org> (raw)
In-Reply-To: <906fb352f231ce3c2f22a176f04d42649d180dda.1556579734.git.v.shpilevoy@tarantool.org>
Pushed to the master as trivial.
On 30/04/2019 02:27, Vladislav Shpilevoy wrote:
> The assertion was checking that a next event object is not the
> same as the previous, but
>
> 1) the previous was deleted already to this moment;
> 2) comparison was done by pointer
>
> The first problem would be enough to drop it. The second is
> already curious - looks like after the old event was deleted,
> the next event was allocated right on the same memory. This is
> why their pointers are equal and the assertion fails.
>
> For example, swim_timer_event_process() - it deletes the event
> object and calls ev_invoke() which can generate a new event on
> the just freed memory.
prev parent reply other threads:[~2019-04-29 23:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 23:27 [tarantool-patches] " Vladislav Shpilevoy
2019-04-29 23:27 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f79cd42d-fca3-6dd9-9807-9b49ea9ab61d@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 1/1] test: drop invalid assert from swim test transport' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox