From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Alex Khatskevich <avkhatskevich@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 2/2] Complete module reload
Date: Tue, 19 Jun 2018 14:57:40 +0300 [thread overview]
Message-ID: <f7672fd7-4706-b716-c8b0-4cffe93769be@tarantool.org> (raw)
In-Reply-To: <c28e754e-2669-28db-2ee2-8df59cc5b5b2@tarantool.org>
>>> +M.discovery_f = discovery_f
>>> +M.failover_f = failover_f
>>
>> 9. Why did you move these lines?
>>
> Because M table should not be changed in case of
> `router_cfg(M.current_cfg)`
> failure
But now router_cfg on reload starts old M.failover_f and
old M.discovery_f, it is not? I think, that if cfg fails on
reload, then the caller should just return to the old
version.
next prev parent reply other threads:[~2018-06-19 11:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-09 17:47 [tarantool-patches] [PATCH 0/2][vshard] Vshard safe reload AKhatskevich
2018-06-09 17:47 ` [tarantool-patches] [PATCH 1/2] Add test on error during reconfigure AKhatskevich
2018-06-17 19:46 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-18 10:10 ` Alex Khatskevich
2018-06-18 10:48 ` Vladislav Shpilevoy
2018-06-19 10:36 ` Alex Khatskevich
2018-06-09 17:47 ` [tarantool-patches] [PATCH 2/2] Complete module reload AKhatskevich
2018-06-17 19:46 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-19 7:09 ` Alex Khatskevich
2018-06-19 9:00 ` Vladislav Shpilevoy
2018-06-19 11:49 ` Alex Khatskevich
2018-06-19 11:57 ` Vladislav Shpilevoy [this message]
2018-06-17 19:39 ` [tarantool-patches] Re: [PATCH 0/2][vshard] Vshard safe reload Vladislav Shpilevoy
2018-06-19 7:20 ` Alex Khatskevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7672fd7-4706-b716-c8b0-4cffe93769be@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=avkhatskevich@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 2/2] Complete module reload' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox