Re: [Tarantool-patches] [PATCH luajit 4/8] ci: use out of source build in GitHub Actions

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi,

LGTM

On 31.08.2022 18:33, Igor Munkin wrote:
> <snipped>
>>> diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml
>>> index 8c8dcff1..21d86764 100644
>>> --- a/.github/workflows/linux-aarch64.yml
>>> +++ b/.github/workflows/linux-aarch64.yml
>>> @@ -53,11 +53,15 @@ jobs:
>>>              sudo apt -y update
>>>              sudo apt -y install cmake gcc make perl
>>>          - name: configure
>>> -        run: cmake . ${{ matrix.CMAKEFLAGS }}
>>> +        run: >
>>> +          cmake -S . -B ${{ env.BUILDDIR }}
>>> +          ${{ matrix.CMAKEFLAGS }}
>>>          - name: build
>>>            run: cmake --build . --parallel
>>> +        working-directory: ${{ env.BUILDDIR }}
>>>          - name: test
>>>            run: cmake --build . --parallel --target test
>>> +        working-directory: ${{ env.BUILDDIR }}
>> 1. I don't get an idea to use current dir for CMake and specify a
>> working-directory in a job step.
>>
>> Why not "cmake --build ${{ env.BUILDDIR }}" as above?
> I tried to not touch the original command. Configuration step can't be
> left intact, but build and test -- can and that makes diff more clear
> (IMHO). Furhermore, it looks more explicit to me: the command is run in
> the current directory, and the current directory is specified
> separately from the command itself.
>
>>>    
>>>      test-tarantool-debug-w-GC64:
>>>        name: Tarantool Debug GC64:ON
> <snipped>
>