From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org
Cc: "v.shpilevoy@tarantool.org" <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 2/2] sql: use own region in Parser
Date: Thu, 31 May 2018 18:49:30 +0300 [thread overview]
Message-ID: <f68c4904-3a72-66ed-35bb-7a67edd5b0be@tarantool.org> (raw)
In-Reply-To: <cd8b050c-cfeb-b626-6199-0bc4e79574d5@tarantool.org>
> 1. Please, use /** for out of a function body comments.
- /* Region to make SQL temp allocations. */
+ /** Region to make SQL temp allocations. */
> 2. Did you check it works now on the Kirill Yu. patch? (with additional field in
> space options).
Yes, I did.
next prev parent reply other threads:[~2018-05-31 15:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 15:01 [tarantool-patches] [PATCH v1 0/2] sql: Create special region for parser Kirill Shcherbatov
2018-05-31 15:01 ` [tarantool-patches] [PATCH v1 1/2] sql: remove parser construct, destruct to sql.h Kirill Shcherbatov
2018-05-31 15:41 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-31 15:49 ` Kirill Shcherbatov
2018-05-31 15:01 ` [tarantool-patches] [PATCH v1 2/2] sql: use own region in Parser Kirill Shcherbatov
2018-05-31 15:41 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-31 15:49 ` Kirill Shcherbatov [this message]
2018-05-31 15:41 ` [tarantool-patches] Re: [PATCH v1 0/2] sql: Create special region for parser Vladislav Shpilevoy
2018-05-31 15:50 ` Kirill Shcherbatov
2018-05-31 15:55 ` Vladislav Shpilevoy
2018-05-31 17:43 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f68c4904-3a72-66ed-35bb-7a67edd5b0be@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 2/2] sql: use own region in Parser' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox