From: Alexander Turenko <alexander.turenko@tarantool.org> To: tarantool-patches@freelists.org Cc: Alexander Turenko <alexander.turenko@tarantool.org> Subject: [tarantool-patches] [PATCH] test: fix test for optional SQL_BIND in iproto Date: Thu, 28 Mar 2019 06:33:32 +0300 [thread overview] Message-ID: <f6520860c4e9a4030e02acaf17c53f581fbd4701.1553743928.git.alexander.turenko@tarantool.org> (raw) Added necessary cleanup, because the test fails when both memtx and vinyl configurations are run on the same test-run worker. Aside of that disabled the test on vinyl, because it is engine-agnostic and only checks iproto. This is the fix for the commit 7676b2b1 ('sql: make SQL_BIND optional in an iproto request'). Follows up #4077. --- https://github.com/tarantool/tarantool/tree/Totktonada/gh-4077-iproto-execute-no-bind-follow-up https://github.com/tarantool/tarantool/issues/4077 test/sql-tap/engine.cfg | 1 + test/sql-tap/gh-4077-iproto-execute-no-bind.test.lua | 3 +++ 2 files changed, 4 insertions(+) diff --git a/test/sql-tap/engine.cfg b/test/sql-tap/engine.cfg index 413dd3ff4..e98528e52 100644 --- a/test/sql-tap/engine.cfg +++ b/test/sql-tap/engine.cfg @@ -11,6 +11,7 @@ "sort.test.lua": { "memtx": {"engine": "memtx"} }, + "gh-4077-iproto-execute-no-bind.test.lua": {}, "*": { "memtx": {"engine": "memtx"}, "vinyl": {"engine": "vinyl"} diff --git a/test/sql-tap/gh-4077-iproto-execute-no-bind.test.lua b/test/sql-tap/gh-4077-iproto-execute-no-bind.test.lua index 55804768c..df548b8e6 100755 --- a/test/sql-tap/gh-4077-iproto-execute-no-bind.test.lua +++ b/test/sql-tap/gh-4077-iproto-execute-no-bind.test.lua @@ -66,4 +66,7 @@ local exp_res = {{1}} local res = box.space.T:pairs():map(box.tuple.totable):totable() test:is_deeply(res, exp_res, 'verify inserted data') +box.sql.execute('drop table T') +box.schema.user.revoke('guest', 'read,write,execute', 'universe') + os.exit(test:check() == true and 0 or 1) -- 2.20.1
next reply other threads:[~2019-03-28 3:33 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-28 3:33 Alexander Turenko [this message] 2019-03-28 3:38 ` [tarantool-patches] " Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f6520860c4e9a4030e02acaf17c53f581fbd4701.1553743928.git.alexander.turenko@tarantool.org \ --to=alexander.turenko@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH] test: fix test for optional SQL_BIND in iproto' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox