From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Georgy Kirichenko <georgy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v2 2/4] wal: wal memory buffer
Date: Tue, 22 Oct 2019 01:04:29 +0200 [thread overview]
Message-ID: <f484048b-4580-6523-ffed-828cb5d3ec00@tarantool.org> (raw)
In-Reply-To: <772fcc2b-bf03-19d1-6431-1b7d2b058865@tarantool.org>
>> +enum {
>> + /*
>> + * Xrow memory object contains some count of rotating data chunks.
>> + * Every rotation estimated decrease in amount of stored rows is
>> + * about 1/(COUNT OF CHUNKS). However the bigger value makes rotation
>> + * more frequent, the decrease would be smoother and size of
>> + * a wal memory more stable.
>
> 27. Please, limit max length of a comment string to 66 symbols. It
> helps reading, no jokes. In the C file too.
Sorry, still out of 66. In many other places too.
next prev parent reply other threads:[~2019-10-21 22:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1568798455.git.georgy@tarantool.org>
[not found] ` <21c3aa57-72c7-a8b1-e9e8-5fbb92f22ed9@tarantool.org>
[not found] ` <20190920075249.GI8859@atlas>
[not found] ` <5842734.CUO0naIOha@home.lan>
2019-10-21 23:03 ` [Tarantool-patches] [tarantool-patches] Re: [PATCH v2 0/4] In-memory wal replication Vladislav Shpilevoy
[not found] ` <4885469.V32OVRv9ck@home.lan>
[not found] ` <c21b86af-ef18-7040-4380-78b01c48203f@tarantool.org>
[not found] ` <2210179.PDX6z0RLMb@home.lan>
[not found] ` <68c06ac1-3a3f-bae2-ebf4-79c1ae63cb64@tarantool.org>
2019-10-21 23:04 ` [Tarantool-patches] [tarantool-patches] Re: [PATCH v2 2/4] wal: wal memory buffer Vladislav Shpilevoy
[not found] ` <68fa00546c99b7b53c1c3024881a19024513104d.1568798455.git.georgy@tarantool.org>
[not found] ` <772fcc2b-bf03-19d1-6431-1b7d2b058865@tarantool.org>
2019-10-21 23:04 ` Vladislav Shpilevoy [this message]
[not found] ` <5dc83b86bbeada22342c355648de2daa7766bb73.1568798455.git.georgy@tarantool.org>
[not found] ` <a6cec753-ce56-f91f-1305-383380a2d630@tarantool.org>
[not found] ` <1816701.j1k7ruT3f3@home.lan>
[not found] ` <569ff681-a670-f4ca-3c6f-75c159e21429@tarantool.org>
2019-10-21 23:04 ` [Tarantool-patches] [tarantool-patches] Re: [PATCH v2 3/4] wal: xrow buffer cursor Vladislav Shpilevoy
[not found] ` <0d9ae1e9b32cb8334bf6007de4cb62ce62f87fcb.1568798455.git.georgy@tarantool.org>
[not found] ` <0db07768-c555-a3f6-12d0-a33a267deaf7@tarantool.org>
2019-10-21 23:05 ` [Tarantool-patches] [tarantool-patches] Re: [PATCH v2 4/4] replication: use wal memory buffer to fetch rows Vladislav Shpilevoy
[not found] ` <2613444.GBVTE10AvH@home.lan>
[not found] ` <84edf0e4-a878-64be-d2f3-694cc672ec9a@tarantool.org>
2019-10-21 23:05 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f484048b-4580-6523-ffed-828cb5d3ec00@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v2 2/4] wal: wal memory buffer' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox