From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] test: flaky replication/gh-5195-qsync-*
Date: Thu, 10 Sep 2020 21:21:56 +0200 [thread overview]
Message-ID: <f3e21e84-b5e3-8e9f-8b66-a51a3b6d07fe@tarantool.org> (raw)
In-Reply-To: <20200910081303.GA11605@hpalx>
>>> diff --git a/test/replication/gh-5195-qsync-replica-write.result b/test/replication/gh-5195-qsync-replica-write.result
>>> index 3999e8f5e..b47359fde 100644
>>> --- a/test/replication/gh-5195-qsync-replica-write.result
>>> +++ b/test/replication/gh-5195-qsync-replica-write.result
>>> @@ -96,10 +96,12 @@ test_run:wait_downstream(replica_id, {status='follow'})
>>> | - true
>>> | ...
>>> test_run:wait_cond(function() \
>>> - local info = box.info.replication[replica_id] \
>>> - local lsn = info.downstream.vclock[replica_id] \
>>> - return lsn and lsn >= replica_lsn \
>>> -end) \
>>> + local lsn = box.info.replication[replica_id].downstream.vclock \
>>
>> 3. It is not lsn, it is vclock now. Also I don't think you need to inline 'info'
>> variable, it was perfectly fine.
>
> Right, the variable name was not correct - fixed. 'info' variable wasn't
> need to be set due to used only once.
That is not about number of usages. It is about code being easier to read
by avoiding too big one-liners.
prev parent reply other threads:[~2020-09-10 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 12:13 Alexander V. Tikhonov
2020-09-09 15:45 ` Serge Petrenko
2020-09-09 21:12 ` Vladislav Shpilevoy
2020-09-10 8:13 ` Alexander V. Tikhonov
2020-09-10 19:21 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3e21e84-b5e3-8e9f-8b66-a51a3b6d07fe@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] test: flaky replication/gh-5195-qsync-*' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox