From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9B81E469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 10 Sep 2020 22:21:57 +0300 (MSK)
References: <0e6d058ce43dcba3b8268a1a09e71e22e287a7db.1599480747.git.avtikhon@tarantool.org>
 <c4f8baf6-a284-feb5-eed3-68a309a5f533@tarantool.org>
 <20200910081303.GA11605@hpalx>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <f3e21e84-b5e3-8e9f-8b66-a51a3b6d07fe@tarantool.org>
Date: Thu, 10 Sep 2020 21:21:56 +0200
MIME-Version: 1.0
In-Reply-To: <20200910081303.GA11605@hpalx>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v1] test: flaky
 replication/gh-5195-qsync-*
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

>>> diff --git a/test/replication/gh-5195-qsync-replica-write.result b/test/replication/gh-5195-qsync-replica-write.result
>>> index 3999e8f5e..b47359fde 100644
>>> --- a/test/replication/gh-5195-qsync-replica-write.result
>>> +++ b/test/replication/gh-5195-qsync-replica-write.result
>>> @@ -96,10 +96,12 @@ test_run:wait_downstream(replica_id, {status='follow'})
>>>   | - true
>>>   | ...
>>>  test_run:wait_cond(function()                                                   \
>>> -        local info = box.info.replication[replica_id]                           \
>>> -        local lsn = info.downstream.vclock[replica_id]                          \
>>> -        return lsn and lsn >= replica_lsn                                       \
>>> -end)                                                                            \
>>> +        local lsn = box.info.replication[replica_id].downstream.vclock          \
>>
>> 3. It is not lsn, it is vclock now. Also I don't think you need to inline 'info'
>> variable, it was perfectly fine.
> 
> Right, the variable name was not correct - fixed. 'info' variable wasn't
> need to be set due to used only once.

That is not about number of usages. It is about code being easier to read
by avoiding too big one-liners.