From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] Disable triggers for _collation during bootstrap
Date: Mon, 19 Nov 2018 13:09:57 +0300 [thread overview]
Message-ID: <f2f331ea-3aae-56b1-a1e9-b96e1c2d184f@tarantool.org> (raw)
In-Reply-To: <20181115150421.24082-1-korablev@tarantool.org>
Hi! Thanks for the patch! LGTM.
On 15/11/2018 18:04, Nikita Pettik wrote:
> After patch that introduced "none" collation (a953051),
> box.internal.bootstrap() started to fail due to inability to drop
> mentioned collation. Lets turn off system triggers for _collation space
> in order to process its complete purification during bootstrap.
> ---
> Branch: https://github.com/tarantool/tarantool/tree/np/none-collation-hotfix
>
> src/box/bootstrap.snap | Bin 1911 -> 1911 bytes
> src/box/lua/upgrade.lua | 1 +
> 2 files changed, 1 insertion(+)
>
> diff --git a/src/box/lua/upgrade.lua b/src/box/lua/upgrade.lua
> index 4b0fd0345..3d9acc976 100644
> --- a/src/box/lua/upgrade.lua
> +++ b/src/box/lua/upgrade.lua
> @@ -70,6 +70,7 @@ local function set_system_triggers(val)
> box.space._func:run_triggers(val)
> box.space._priv:run_triggers(val)
> box.space._trigger:run_triggers(val)
> + box.space._collation:run_triggers(val)
> end
>
> --------------------------------------------------------------------------------
>
next prev parent reply other threads:[~2018-11-19 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 15:04 [tarantool-patches] " Nikita Pettik
2018-11-19 10:09 ` Vladislav Shpilevoy [this message]
2018-11-19 17:44 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2f331ea-3aae-56b1-a1e9-b96e1c2d184f@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] Disable triggers for _collation during bootstrap' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox