From: imeevma@tarantool.org
To: v.shpilevoy@tarantool.org, lvasiliev@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1 1/1] sql: remove unecessary execute of space_cache_find()
Date: Sat, 5 Dec 2020 12:35:21 +0300 [thread overview]
Message-ID: <f22c12a6cbd360e0b3c8177c8c05932ba99728fa.1607160717.git.imeevma@gmail.com> (raw)
Due to the fact that space_cache_find () is called unnecessarily, it is
possible to set diag "Space '0' does not exist", although in this case
it is not a wrong situation when the space id is 0.
Part of #5592
---
https://github.com/tarantool/tarantool/issues/5592
https://github.com/tarantool/tarantool/tree/imeevma/gh-5592-remove-unnecessary-diag-set
src/box/sql/where.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/box/sql/where.c b/src/box/sql/where.c
index 0d7590f0e..65d4197f2 100644
--- a/src/box/sql/where.c
+++ b/src/box/sql/where.c
@@ -4581,7 +4581,7 @@ sqlWhereBegin(Parse * pParse, /* The parser context */
struct SrcList_item *pTabItem = &pTabList->a[pLevel->iFrom];
struct space_def *space_def = pTabItem->space->def;
pLoop = pLevel->pWLoop;
- struct space *space = space_cache_find(space_def->id);
+ struct space *space = pTabItem->space;
if (space_def->id == 0 || space_def->opts.is_view) {
/* Do nothing */
} else if ((pLoop->wsFlags & WHERE_IDX_ONLY) == 0 &&
--
2.25.1
next reply other threads:[~2020-12-05 9:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 9:35 imeevma [this message]
2020-12-05 17:06 ` Vladislav Shpilevoy
2020-12-05 19:57 ` Mergen Imeev
2020-12-06 15:19 ` Vladislav Shpilevoy
2020-12-07 14:17 ` Nikita Pettik
2020-12-07 14:28 ` Mergen Imeev
2020-12-07 14:57 ` Nikita Pettik
2020-12-09 6:53 ` Mergen Imeev
2020-12-10 13:28 ` Mergen Imeev
2020-12-10 13:38 ` Nikita Pettik
2020-12-11 13:43 ` Alexander V. Tikhonov
2020-12-11 14:30 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f22c12a6cbd360e0b3c8177c8c05932ba99728fa.1607160717.git.imeevma@gmail.com \
--to=imeevma@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove unecessary execute of space_cache_find()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox