From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0B0D145C305 for ; Sat, 5 Dec 2020 12:35:22 +0300 (MSK) From: imeevma@tarantool.org Date: Sat, 5 Dec 2020 12:35:21 +0300 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v1 1/1] sql: remove unecessary execute of space_cache_find() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: v.shpilevoy@tarantool.org, lvasiliev@tarantool.org Cc: tarantool-patches@dev.tarantool.org Due to the fact that space_cache_find () is called unnecessarily, it is possible to set diag "Space '0' does not exist", although in this case it is not a wrong situation when the space id is 0. Part of #5592 --- https://github.com/tarantool/tarantool/issues/5592 https://github.com/tarantool/tarantool/tree/imeevma/gh-5592-remove-unnecessary-diag-set src/box/sql/where.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/box/sql/where.c b/src/box/sql/where.c index 0d7590f0e..65d4197f2 100644 --- a/src/box/sql/where.c +++ b/src/box/sql/where.c @@ -4581,7 +4581,7 @@ sqlWhereBegin(Parse * pParse, /* The parser context */ struct SrcList_item *pTabItem = &pTabList->a[pLevel->iFrom]; struct space_def *space_def = pTabItem->space->def; pLoop = pLevel->pWLoop; - struct space *space = space_cache_find(space_def->id); + struct space *space = pTabItem->space; if (space_def->id == 0 || space_def->opts.is_view) { /* Do nothing */ } else if ((pLoop->wsFlags & WHERE_IDX_ONLY) == 0 && -- 2.25.1