From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@dev.tarantool.org, korablev@tarantool.org, tsafin@tarantool.org, alyapunov@tarantool.org, gorcunov@gmail.com Subject: [Tarantool-patches] [PATCH 02/10] cmake: ignore warnings on alignof() and offsetof() Date: Thu, 21 May 2020 22:37:25 +0200 [thread overview] Message-ID: <f1e1fa3a085cab399a19474389d810f64589b6c3.1590093222.git.v.shpilevoy@tarantool.org> (raw) In-Reply-To: <cover.1590093222.git.v.shpilevoy@tarantool.org> Warning about invalid offsetof() (used on non-POD types) was set for g++, but wasn't for clang++. Warning about invalid alignof() (when expression is passed to it instead of a type) wasn't ignored, but is going to be very useful in upcoming unaligned memory access patches. That allows to write something like: struct some_long_type *object = region_aligned_alloc( region, size, alignof(*object)); This will work even if type of 'object' will change in future, and so it is safer. And shorter. Part of #4609 --- cmake/compiler.cmake | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmake/compiler.cmake b/cmake/compiler.cmake index 56429dc20..ce3e7e506 100644 --- a/cmake/compiler.cmake +++ b/cmake/compiler.cmake @@ -276,11 +276,12 @@ macro(enable_tnt_compile_flags) add_compile_flags("C;CXX" "-Wno-format-truncation") endif() - if (CMAKE_COMPILER_IS_GNUCXX) + if (CMAKE_COMPILER_IS_CLANG OR CMAKE_COMPILER_IS_GNUCXX) # G++ bug. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31488 add_compile_flags("CXX" "-Wno-invalid-offsetof" ) + add_compile_flags("C;CXX" "-Wno-gnu-alignof-expression") endif() if (CMAKE_COMPILER_IS_GNUCC) -- 2.21.1 (Apple Git-122.3)
next prev parent reply other threads:[~2020-05-21 20:37 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-21 20:37 [Tarantool-patches] [PATCH 00/10] Sanitize unaligned access Vladislav Shpilevoy 2020-05-21 20:37 ` [Tarantool-patches] [PATCH 01/10] small: sanitized rlist and new region API Vladislav Shpilevoy 2020-06-08 12:17 ` Cyrill Gorcunov 2020-05-21 20:37 ` [Tarantool-patches] [PATCH 10/10] xrow: use unaligned store operation in xrow_to_iovec() Vladislav Shpilevoy 2020-06-08 12:26 ` Cyrill Gorcunov 2020-05-21 20:37 ` Vladislav Shpilevoy [this message] 2020-06-08 12:52 ` [Tarantool-patches] [PATCH 02/10] cmake: ignore warnings on alignof() and offsetof() Cyrill Gorcunov 2020-05-21 20:37 ` [Tarantool-patches] [PATCH 03/10] cmake: add option ENABLE_UB_SANITIZER Vladislav Shpilevoy 2020-06-08 12:53 ` Cyrill Gorcunov 2020-05-21 20:37 ` [Tarantool-patches] [PATCH 04/10] crc32: disable align sanitizer Vladislav Shpilevoy 2020-06-08 13:58 ` Cyrill Gorcunov 2020-05-21 20:37 ` [Tarantool-patches] [PATCH 05/10] sql: make BtCursor's memory aligned Vladislav Shpilevoy 2020-06-08 13:58 ` Cyrill Gorcunov 2020-05-21 20:37 ` [Tarantool-patches] [PATCH 06/10] region: use aligned allocations where necessary Vladislav Shpilevoy 2020-06-08 14:00 ` Cyrill Gorcunov 2020-05-21 20:37 ` [Tarantool-patches] [PATCH 07/10] vinyl: align statements and bps tree extents Vladislav Shpilevoy 2020-06-08 14:02 ` Cyrill Gorcunov 2020-05-21 20:37 ` [Tarantool-patches] [PATCH 08/10] tuple: use unaligned store-load for field map Vladislav Shpilevoy 2020-06-08 14:04 ` Cyrill Gorcunov 2020-05-21 20:37 ` [Tarantool-patches] [PATCH 09/10] port: make port_c_entry not PACKED Vladislav Shpilevoy 2020-06-08 14:04 ` Cyrill Gorcunov 2020-05-21 22:25 ` [Tarantool-patches] [PATCH 00/10] Sanitize unaligned access Sergey Bronnikov 2020-05-27 23:33 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f1e1fa3a085cab399a19474389d810f64589b6c3.1590093222.git.v.shpilevoy@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=alyapunov@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=tsafin@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 02/10] cmake: ignore warnings on alignof() and offsetof()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox