From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Drop finalizer table rehash after GC cycle.
Date: Thu, 19 Sep 2024 12:02:51 +0300 [thread overview]
Message-ID: <euyj2ysvnhbkwjsmrhhwbpicio5lqbbc4npchc7opmdartetgv@4nr2z5afcx24> (raw)
In-Reply-To: <Zt8DB232xEUUg93U@root>
Hi, Sergey!
Thanks for the patch!
LGTM
On Mon, Sep 09, 2024 at 05:15:35PM GMT, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
>
> On 09.09.24, Sergey Bronnikov wrote:
> > Hi, Sergey,
> >
> >
> > thanks for the fixes. Please replace "grop" to "grow" in commit
> >
> > message. LGTM
>
> Fixed, thanks!
> Branch is force-pushed.
>
> --
> Best regards,
> Sergey Kaplun
next prev parent reply other threads:[~2024-09-19 9:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 12:54 Sergey Kaplun via Tarantool-patches
2024-09-06 14:42 ` Sergey Bronnikov via Tarantool-patches
2024-09-07 5:15 ` Sergey Kaplun via Tarantool-patches
2024-09-09 13:37 ` Sergey Bronnikov via Tarantool-patches
2024-09-09 14:15 ` Sergey Kaplun via Tarantool-patches
2024-09-19 9:02 ` Maxim Kokryashkin via Tarantool-patches [this message]
2024-09-19 11:19 ` [Tarantool-patches] [PATCH luajit] Drop unused function wrapper Sergey Kaplun via Tarantool-patches
2024-09-19 11:30 ` Maxim Kokryashkin via Tarantool-patches
2024-09-19 18:53 ` Sergey Bronnikov via Tarantool-patches
2024-10-18 15:13 ` [Tarantool-patches] [PATCH luajit] FFI: Drop finalizer table rehash after GC cycle Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=euyj2ysvnhbkwjsmrhhwbpicio5lqbbc4npchc7opmdartetgv@4nr2z5afcx24 \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] FFI: Drop finalizer table rehash after GC cycle.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox