[Tarantool-patches] [PATCH luajit] c: bump version of actions/checkout

[Tarantool-patches] [PATCH luajit] c: bump version of actions/checkout

[Sergey Bronnikov via Tarantool-patches]

From: Sergey Bronnikov <sergeyb@tarantool.org>

Bump version of actions/checkout to v4.
Bump fixes an annoying warning that appears in Github WebUI:

Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20: actions/checkout@v3. For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
---
 .github/workflows/coverage.yml               | 2 +-
 .github/workflows/exotic-builds-testing.yml  | 2 +-
 .github/workflows/gnumake-builds-testing.yml | 2 +-
 .github/workflows/lint.yml                   | 2 +-
 .github/workflows/sanitizers-testing.yml     | 2 +-
 .github/workflows/testing.yml                | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
index 89571361..416e26da 100644
--- a/.github/workflows/coverage.yml
+++ b/.github/workflows/coverage.yml
@@ -32,7 +32,7 @@ jobs:
       fail-fast: false
     runs-on: [self-hosted, regular, x86_64, Linux]
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
index a9ba5fd5..859603bd 100644
--- a/.github/workflows/exotic-builds-testing.yml
+++ b/.github/workflows/exotic-builds-testing.yml
@@ -63,7 +63,7 @@ jobs:
       ${{ matrix.BUILDTYPE }}
       GC64:${{ matrix.GC64 }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml
index afb96183..1b64b040 100644
--- a/.github/workflows/gnumake-builds-testing.yml
+++ b/.github/workflows/gnumake-builds-testing.yml
@@ -59,7 +59,7 @@ jobs:
       ${{ matrix.BUILDTYPE }}
       GC64:${{ matrix.GC64 }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 7e618657..85e1b646 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -31,7 +31,7 @@ jobs:
     runs-on: [self-hosted, lightweight, Linux, x86_64]
     name: LuaJIT linters (luacheck, flake8, codespell)
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml
index 4bccfcef..3d42265e 100644
--- a/.github/workflows/sanitizers-testing.yml
+++ b/.github/workflows/sanitizers-testing.yml
@@ -44,7 +44,7 @@ jobs:
       ${{ matrix.BUILDTYPE }}
       GC64:ON SYSMALLOC:ON
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
index cb4ba57b..932f745f 100644
--- a/.github/workflows/testing.yml
+++ b/.github/workflows/testing.yml
@@ -59,7 +59,7 @@ jobs:
       GC64:${{ matrix.GC64 }}
       CC:${{ matrix.CC }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
-- 
2.34.1

Re: [Tarantool-patches] [PATCH luajit] c: bump version of actions/checkout

[Maxim Kokryashkin via Tarantool-patches]

Hi, Sergey!
Thanks for the patch!
LGTM, except for a few nits regarding the commit message.
On Tue, Mar 12, 2024 at 04:51:02PM +0300, Sergey Bronnikov wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
Patch header contains a typo.
Typo: s/c:/ci:/
>
> Bump version of actions/checkout to v4.
> Bump fixes an annoying warning that appears in Github WebUI:
Typo: s/in/in the/
>
> Node.js 16 actions are deprecated. Please update the following actions
> to use Node.js 20: actions/checkout@v3. For more information see:
> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
It would be nicer to emphasize the message with | on each line:
| Node.js 16 actions are deprecated. Please update the following actions
| to use Node.js 20: actions/checkout@v3. For more information see:
| https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

> ---
>  .github/workflows/coverage.yml               | 2 +-
>  .github/workflows/exotic-builds-testing.yml  | 2 +-
>  .github/workflows/gnumake-builds-testing.yml | 2 +-
>  .github/workflows/lint.yml                   | 2 +-
>  .github/workflows/sanitizers-testing.yml     | 2 +-
>  .github/workflows/testing.yml                | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
>
<snipped>

Re: [Tarantool-patches] [PATCH luajit] c: bump version of actions/checkout

[Sergey Bronnikov via Tarantool-patches]

Max,

thanks for review! Fixed and force-pushed.

On 3/13/24 11:56, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for a few nits regarding the commit message.
> On Tue, Mar 12, 2024 at 04:51:02PM +0300, Sergey Bronnikov wrote:
>> From: Sergey Bronnikov <sergeyb@tarantool.org>
> Patch header contains a typo.
> Typo: s/c:/ci:/
Fixed.
>> Bump version of actions/checkout to v4.
>> Bump fixes an annoying warning that appears in Github WebUI:
> Typo: s/in/in the/
Fixed.
>> Node.js 16 actions are deprecated. Please update the following actions
>> to use Node.js 20: actions/checkout@v3. For more information see:
>> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
> It would be nicer to emphasize the message with | on each line:
> | Node.js 16 actions are deprecated. Please update the following actions
> | to use Node.js 20: actions/checkout@v3. For more information see:
> | https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Fixed.
>
>> ---
>>   .github/workflows/coverage.yml               | 2 +-
>>   .github/workflows/exotic-builds-testing.yml  | 2 +-
>>   .github/workflows/gnumake-builds-testing.yml | 2 +-
>>   .github/workflows/lint.yml                   | 2 +-
>>   .github/workflows/sanitizers-testing.yml     | 2 +-
>>   .github/workflows/testing.yml                | 2 +-
>>   6 files changed, 6 insertions(+), 6 deletions(-)
>>
> <snipped>

Re: [Tarantool-patches] [PATCH luajit] c: bump version of actions/checkout

[Sergey Kaplun via Tarantool-patches]

Hi, Sergey!
Thanks for the patch and fixes!
LGTM!

-- 
Best regards,
Sergey Kaplun

Re: [Tarantool-patches] [PATCH luajit] c: bump version of actions/checkout

[Sergey Kaplun via Tarantool-patches]

Sergey,

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master [1], release/3.0 [2]
and release/2.11 [3].

[1]: https://github.com/tarantool/tarantool/pull/9938
[2]: https://github.com/tarantool/tarantool/pull/9939
[3]: https://github.com/tarantool/tarantool/pull/9940

-- 
Best regards,
Sergey Kaplun