Tarantool development patches archive
 help / color / mirror / Atom feed
From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <estetus@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] c: bump version of actions/checkout
Date: Wed, 13 Mar 2024 11:56:41 +0300	[thread overview]
Message-ID: <enyzvqlzdjltcjecycipnvuutn7mnzkyqphadqssl6tzd63rgt@3i3xfbj44opc> (raw)
In-Reply-To: <93809031fbffd82c29538d652c4418e12db7baaf.1710251441.git.sergeyb@tarantool.org>

Hi, Sergey!
Thanks for the patch!
LGTM, except for a few nits regarding the commit message.
On Tue, Mar 12, 2024 at 04:51:02PM +0300, Sergey Bronnikov wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
Patch header contains a typo.
Typo: s/c:/ci:/
>
> Bump version of actions/checkout to v4.
> Bump fixes an annoying warning that appears in Github WebUI:
Typo: s/in/in the/
>
> Node.js 16 actions are deprecated. Please update the following actions
> to use Node.js 20: actions/checkout@v3. For more information see:
> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
It would be nicer to emphasize the message with | on each line:
| Node.js 16 actions are deprecated. Please update the following actions
| to use Node.js 20: actions/checkout@v3. For more information see:
| https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

> ---
>  .github/workflows/coverage.yml               | 2 +-
>  .github/workflows/exotic-builds-testing.yml  | 2 +-
>  .github/workflows/gnumake-builds-testing.yml | 2 +-
>  .github/workflows/lint.yml                   | 2 +-
>  .github/workflows/sanitizers-testing.yml     | 2 +-
>  .github/workflows/testing.yml                | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
>
<snipped>

  reply	other threads:[~2024-03-13  8:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12 13:51 Sergey Bronnikov via Tarantool-patches
2024-03-13  8:56 ` Maxim Kokryashkin via Tarantool-patches [this message]
2024-03-13  9:10   ` Sergey Bronnikov via Tarantool-patches
2024-03-21  7:57 ` Sergey Kaplun via Tarantool-patches
2024-04-11 17:05 ` Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=enyzvqlzdjltcjecycipnvuutn7mnzkyqphadqssl6tzd63rgt@3i3xfbj44opc \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=estetus@gmail.com \
    --cc=m.kokryashkin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] c: bump version of actions/checkout' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox