[tarantool-patches] Re: [PATCH v1 2/3] box: stacked diagnostics area in fiber

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the patch! See 2 comments below.

On 01/08/2019 13:13, Kirill Shcherbatov wrote:
> This patch introduces stacked errors. A new API diag_add allows
> to extend an existent error information with a new one error.

1. 'a' assumes singular. You can and usually should omit 'one'.

> The previous state becomes a "reason" of the last-set error.
> Each error object takes a reference to it's reason error object.
> 
> The :unpack() method patched correspondingly to display the whole
> errors trace.
> 
> Part of #1148
> ---
> diff --git a/test/engine/func_index.result b/test/engine/func_index.result
> index 877b76d5e..ae8873c9b 100644
> --- a/test/engine/func_index.result
> +++ b/test/engine/func_index.result
> @@ -189,6 +188,16 @@ s:insert({1})
>   | - error: 'Key format doesn''t match one defined in functional index ''idx'' of space
>   |     ''withdata'': to many values were returned'
>   | ...
> +box.error.last():unpack()
> + | ---
> + | - - type: ClientError
> + |     code: 199
> + |     message: 'Key format doesn''t match one defined in functional index ''idx'' of
> + |       space ''withdata'': to many values were returned'
> + |     trace:
> + |     - file: /home/kir/WORK/tarantool/src/box/key_list.c
> + |       line: 95

2. Firstly, if you change something on the branch, then please, write about in an email.
On the branch I see that you added filters. Lets filter out the line as well. Otherwise
that test will fail each time we add or delete any of first 95 lines of key_list.c.

> + | ...
>  idx:drop()
>   | ---
>   | ...