From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: alexander.turenko@tarantool.org
Cc: tarantool-patches@freelists.org
Subject: [PATCH] cmake: fix sync_file_range detection
Date: Sat, 6 Oct 2018 17:51:48 +0300 [thread overview]
Message-ID: <ee711b32d79fcc65b6854f28a476354a75d67604.1538835045.git.vdavydov.dev@gmail.com> (raw)
sync_file_range is declared only if _GNU_SOURCE macro is defined.
Also, in order to be used in a source file, HAVE_SYNC_FILE_RANGE
must be present in config.h.cmake.
Fixes commit caae99e5eaa0 ("Refactor xlog writer").
---
https://github.com/tarantool/tarantool/commits/dv/cmake-fix-gnu-symbol-detection
CMakeLists.txt | 2 ++
src/trivia/config.h.cmake | 1 +
2 files changed, 3 insertions(+)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index bf68d187..b26d2abf 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -69,6 +69,8 @@ include(cmake/profile.cmake)
include(cmake/module.cmake)
include(cmake/thread.cmake)
+list(APPEND CMAKE_REQUIRED_DEFINITIONS -D_GNU_SOURCE)
+
check_symbol_exists(MAP_ANON sys/mman.h HAVE_MAP_ANON)
check_symbol_exists(MAP_ANONYMOUS sys/mman.h HAVE_MAP_ANONYMOUS)
check_include_file(sys/time.h HAVE_SYS_TIME_H)
diff --git a/src/trivia/config.h.cmake b/src/trivia/config.h.cmake
index 66ddba99..8894b436 100644
--- a/src/trivia/config.h.cmake
+++ b/src/trivia/config.h.cmake
@@ -167,6 +167,7 @@
#cmakedefine HAVE_SCHED_YIELD 1
#cmakedefine HAVE_POSIX_FADVISE 1
#cmakedefine HAVE_MREMAP 1
+#cmakedefine HAVE_SYNC_FILE_RANGE 1
#cmakedefine HAVE_PRCTL_H 1
--
2.11.0
next reply other threads:[~2018-10-06 14:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-06 14:51 Vladimir Davydov [this message]
2018-10-08 3:04 ` Alexander Turenko
2018-10-08 8:00 ` Vladimir Davydov
2018-10-08 9:23 ` Alexander Turenko
2018-10-08 10:30 ` Vladimir Davydov
2018-10-08 13:14 ` Alexander Turenko
2018-10-08 14:42 ` Vladimir Davydov
2018-10-16 18:55 ` [tarantool-patches] " Konstantin Osipov
2018-10-17 7:13 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee711b32d79fcc65b6854f28a476354a75d67604.1538835045.git.vdavydov.dev@gmail.com \
--to=vdavydov.dev@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] cmake: fix sync_file_range detection' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox