From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Mergen Imeev <imeevma@tarantool.org>,
tsafin@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 6/6] sql: remove OP_ApplyType
Date: Wed, 10 Jun 2020 00:29:52 +0200 [thread overview]
Message-ID: <ee59fb81-9120-3d79-cb99-3016eba6ca87@tarantool.org> (raw)
In-Reply-To: <b30753fd73baa19c2e25647a3cd6b0e130956da3.1590671266.git.imeevma@gmail.com>
Thanks for the patch!
> diff --git a/src/box/sql/wherecode.c b/src/box/sql/wherecode.c
> index 1d7c76670..1ec9f4ed7 100644
> --- a/src/box/sql/wherecode.c
> +++ b/src/box/sql/wherecode.c
> @@ -571,7 +571,7 @@ codeEqualityTerm(Parse * pParse, /* The parsing context */
> *
> * Before returning, @types is set to point to a buffer containing a
> * copy of the column types array of the index allocated using
> - * sqlDbMalloc(). This array is passed to OP_ApplyType to provide
> + * sqlDbMalloc(). This array is passed to OP_CheckType to provide
@types parameter does not exist anymore. I guess it was removed in
one of the previous commits, and the comment should be updated there
too.
> * correct implicit conversions.
> */
> static int
next prev parent reply other threads:[~2020-06-09 22:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 14:17 [Tarantool-patches] [PATCH 0/6] Remove implicit cast Mergen Imeev
2020-05-28 14:17 ` [Tarantool-patches] [PATCH 1/6] sql: remove implicit cast for assignment Mergen Imeev
2020-06-01 17:03 ` Vladislav Shpilevoy
2020-06-09 11:41 ` Mergen Imeev
2020-06-09 22:28 ` Vladislav Shpilevoy
2020-05-28 14:17 ` [Tarantool-patches] [PATCH 2/6] sql: remove mem_apply_type() from OP_MakeRecord Mergen Imeev
2020-06-01 17:03 ` Vladislav Shpilevoy
2020-06-09 11:43 ` Mergen Imeev
2020-05-28 14:17 ` [Tarantool-patches] [PATCH 3/6] sql: replace ApplyType by CheckType for IN operator Mergen Imeev
2020-05-28 14:17 ` [Tarantool-patches] [PATCH 4/6] sql: remove mem_apply_type() from OP_MustBeInt Mergen Imeev
2020-06-01 17:04 ` Vladislav Shpilevoy
2020-06-09 11:47 ` Mergen Imeev
2020-06-09 22:28 ` Vladislav Shpilevoy
2020-05-28 14:17 ` [Tarantool-patches] [PATCH 5/6] sql: remove implicit cast from string for comparison Mergen Imeev
2020-06-01 17:04 ` Vladislav Shpilevoy
2020-06-09 11:51 ` Mergen Imeev
2020-06-09 22:29 ` Vladislav Shpilevoy
2020-05-28 14:17 ` [Tarantool-patches] [PATCH 6/6] sql: remove OP_ApplyType Mergen Imeev
2020-06-09 22:29 ` Vladislav Shpilevoy [this message]
2020-06-01 17:03 ` [Tarantool-patches] [PATCH 0/6] Remove implicit cast Vladislav Shpilevoy
2020-06-09 11:25 ` Mergen Imeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee59fb81-9120-3d79-cb99-3016eba6ca87@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 6/6] sql: remove OP_ApplyType' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox