From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org>
Subject: Re: [tarantool-patches] Re: [PATCH 0/5] JSON update preparation
Date: Wed, 31 Jul 2019 22:36:06 +0200 [thread overview]
Message-ID: <ee1ff8db-ba65-c92f-548f-dfe303d58397@tarantool.org> (raw)
In-Reply-To: <20190731121531.GN4659@esperanza>
I can't believe that you've watched this huge patchset, and
don't have a single comment. But ok, understandable.
Kirill, I've rebased it, made a couple of minor changes, and
force pushed to the branch. You can merge, or propose who else
could review this.
On 31/07/2019 14:15, Vladimir Davydov wrote:
> On Sun, Jul 14, 2019 at 12:11:03AM +0200, Vladislav Shpilevoy wrote:
>> The patchset is mainly about rope and its usage. Rope is a data structure
>> allowing to modify an array with memory overhead not depending on the array
>> size. Only on the number of modifications. It is used when there is a long
>> array of something, and a one wants to insert new elements, delete existing
>> ones, change their values, but do not rebuild the whole array each time.
>>
>> Rope is going to be one of the core data structures of the incoming JSON path
>> updates, and this patchset makes it faster and lighter.
>>
>> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-1261-update-json-prepare
>> Issue: https://github.com/tarantool/tarantool/issues/1261
>>
>> Vladislav Shpilevoy (5):
>> tuple: remove alloc and alloc_ctx args from update()
>> rope: make rope library macro template
>> tuple: relax struct tuple_update dependency on rope
>> int96: add a missing header
>> tuple: implement update by field name
>
> LGTM
>
next prev parent reply other threads:[~2019-07-31 20:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 22:11 Vladislav Shpilevoy
2019-07-13 22:11 ` [PATCH 1/5] tuple: remove alloc and alloc_ctx args from update() Vladislav Shpilevoy
2019-07-13 22:11 ` [PATCH 2/5] rope: make rope library macro template Vladislav Shpilevoy
2019-07-13 22:11 ` [PATCH 3/5] tuple: relax struct tuple_update dependency on rope Vladislav Shpilevoy
2019-07-13 22:11 ` [PATCH 4/5] int96: add a missing header Vladislav Shpilevoy
2019-07-13 22:11 ` [PATCH 5/5] tuple: implement update by field name Vladislav Shpilevoy
2019-07-31 12:15 ` [PATCH 0/5] JSON update preparation Vladimir Davydov
2019-07-31 20:36 ` Vladislav Shpilevoy [this message]
2019-08-22 21:18 ` [tarantool-patches] " Vladislav Shpilevoy
2019-08-27 22:08 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee1ff8db-ba65-c92f-548f-dfe303d58397@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH 0/5] JSON update preparation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox