Re: [Tarantool-patches] [PATCH 1/2] gdb: adjust to support python2 (centos 7)

[Mikhail Elhimov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!

Thanks for the review!

On 20.08.2022 09:26, Sergey Kaplun wrote:
> Hi, Mikhail!
>
> Thanks for the patch!
> Sorry, for such long waiting.
> It's LGTM, except a few stylish comments regarding the commit message.
>
> On 23.07.22, Mikhail Elhimov via Tarantool-patches wrote:
>> Stop using unpacking arguments within list initialization as python2
> Typo: s/list initialization/the list initialization/
> Also, you may mention that this problem affected Lua stack dump.
Fixed
>
>> only supports it in function call
> Typo: s/function call/a function call/
>
> Missed dot at the end of the sentence.
Fixed
>
>> fixes tarantool/luajit#7458
> Typo:
> Fixes tarantool/tarantool#7458
Fixed
>
>> ---
>>   src/luajit-gdb.py | 22 ++++++++++++----------
>>   1 file changed, 12 insertions(+), 10 deletions(-)
>>
>> diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py
>> index baf66f66..1e9a96fb 100644
>> --- a/src/luajit-gdb.py
>> +++ b/src/luajit-gdb.py
> <snipped>
>
>> -- 
>> 2.34.1
>>
The corrected commit message:
=================================================
gdb: adjust to support python2 (centos 7)

Stop using unpacking arguments within the list initialization as python2
only supports it in a function call (it affected Lua stack dump).

Fixes tarantool/tarantool#7458
=================================================

-- 
Best regards,
Mikhail Elhimov