From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Yaroslav Dynnikov <yaroslav.dynnikov@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] Ensure all curl symbols are exported
Date: Wed, 12 Aug 2020 22:10:13 +0200 [thread overview]
Message-ID: <ed9167a7-3f33-8b62-be5b-3357b4fae9b8@tarantool.org> (raw)
In-Reply-To: <CAK0MaD1wyqaNO2zteOsnZer6W+Z2pcs-PnkT0i+sXcwjOJg+Rg@mail.gmail.com>
On 12.08.2020 14:59, Yaroslav Dynnikov wrote:
> Hi, Vlad.
>
> Number 7 is the libcurl age. According to the documentation, age should be set to the version of this functionality by the time you write your program. This way, libcurl will always return a proper struct that your program understands, while programs in the future might get a different struct. See https://curl.haxx.se/libcurl/c/curl_version_info.html
>
> So it's safe enough to rely on the structure. And I think both checkes (libssl and libz) are important enough to be tracked by tests. We don't want them to be silently gone, do we?
Still the test is overcomplicated, I think. But at least it should be stable, if
with the same age number all curl versions will return the same curl_version_info_data.
LGTM.
next prev parent reply other threads:[~2020-08-12 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 13:19 Yaroslav Dynnikov
2020-08-06 15:06 ` Timur Safin
2020-08-10 22:49 ` Vladislav Shpilevoy
2020-08-12 12:59 ` Yaroslav Dynnikov
2020-08-12 20:10 ` Vladislav Shpilevoy [this message]
2020-08-13 11:48 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed9167a7-3f33-8b62-be5b-3357b4fae9b8@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=yaroslav.dynnikov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Ensure all curl symbols are exported' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox