From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v4 6/8] sql: refactor AST trigger object name
Date: Wed, 27 Jun 2018 21:04:40 +0300 [thread overview]
Message-ID: <ed452fdb-caf5-0a34-b6e5-a548d9a94e37@tarantool.org> (raw)
In-Reply-To: <AEFCD088-54C0-47BC-AD9A-68EE69BD2DE9@tarantool.org>
> I mean not all of these variables are initialised. For example, you can move
- /* Name of trigger. */
- char *trigger_name;
/* SQL text. */
char *sql_str = NULL;
/* MsgPack containing SQL options. */
@@ -190,7 +188,7 @@ sql_trigger_finish(struct Parse *parse, struct TriggerStep *step_list,
parse->parsed_ast.trigger = NULL;
if (NEVER(parse->nErr) || trigger == NULL)
goto triggerfinish_cleanup;
- trigger_name = trigger->zName;
+ char *trigger_name = trigger->zName;
Ok, as you wish.
next prev parent reply other threads:[~2018-06-27 18:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1530029141.git.kshcherbatov@tarantool.org>
2018-06-26 16:13 ` [tarantool-patches] " Kirill Shcherbatov
2018-06-27 15:57 ` [tarantool-patches] " n.pettik
2018-06-27 16:35 ` Kirill Shcherbatov
2018-06-27 17:41 ` n.pettik
2018-06-27 18:04 ` Kirill Shcherbatov [this message]
2018-06-26 16:13 ` [tarantool-patches] [PATCH v4 8/8] sql: remove global sql_trigger hash Kirill Shcherbatov
2018-06-27 17:28 ` [tarantool-patches] " n.pettik
2018-06-27 18:04 ` Kirill Shcherbatov
2018-06-28 19:17 ` Vladislav Shpilevoy
2018-06-29 13:28 ` Kirill Shcherbatov
2018-06-29 13:31 ` Vladislav Shpilevoy
2018-06-29 13:54 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed452fdb-caf5-0a34-b6e5-a548d9a94e37@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v4 6/8] sql: refactor AST trigger object name' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox