Re: [Tarantool-patches] [PATCH] tools: implement toolchain for crash artefacts

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Igor,

thanks for changes! Generally LGTM with two notes inline.

On 11.03.2021 15:13, Igor Munkin wrote:
> Sergey,
>
> Thanks for your review!
>
> On 03.03.21, Sergey Bronnikov wrote:
<skipped>
>> 2. I propose to show files included to the report and the end of creation.
> Well, I believe I didn't understand you right before (this list is
> included to the archive). Anyway, now I added the list also to the
> message at the end.

You got it right.

<skipped>


1. in a private conversation we decided to remove mention of public 
resource in a message "http://transfer.sh".


 >  - Manual usage. User can simply pack all necessary artefacts by 
running the
 >    following command.
 >    $ /path/to/${TOOL} -c ./core -d /tmp
 >
 >  - Automatic usage. If user faces the failures often, one can set 
this script
 >    as a pipe reciever in kernel.core_pattern syntax.
 >    # sysctl -w kernel.core_pattern="|/absolute/path/to/${TOOL} -d 
/var/core -p %p -t %t"

2. it would be more convenient to set real path to tarabrt.sh in a 
usage, see patch below

--- a/tools/tarabrt.sh
+++ b/tools/tarabrt.sh
@@ -2,6 +2,8 @@
  set -eu

  TOOL=$(basename "$0")
+#TOOLPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )"
+TOOLPATH=$(realpath -s $0)
  HELP=$(cat <<HELP
  ${TOOL} - Tarantool Automatic Bug Reporting Tool

@@ -45,11 +47,11 @@ USAGE

    - Manual usage. User can simply pack all necessary artefacts by 
running the
      following command.
-    $ /path/to/${TOOL} -c ./core -d /tmp
+    $ ${TOOLPATH} -c ./core -d /tmp

    - Automatic usage. If user faces the failures often, one can set 
this script
      as a pipe reciever in kernel.core_pattern syntax.
-    # sysctl -w kernel.core_pattern="|/absolute/path/to/${TOOL} -d 
/var/core -p %p -t %t"
+    # sysctl -w kernel.core_pattern="|${TOOLPATH} -d /var/core -p %p -t %t"

  HELP
  )