From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DCE7A6FC86; Wed, 24 Mar 2021 19:03:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DCE7A6FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616601781; bh=ms1W1sclOtdDpa2LaMo7s6D+EtTYhpPJC5G5WybhBKA=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=XqeJ2X+vH/hw1Y/xHoAm+0VzHURjsf57fT6njtp6iQl59iaet3DIc11r0D7EOoY9M EWNP4qAXYjjmMlMEUqyUYVSu++Hl7eCYh1NQJtKsDqZOjQ/inlk1Zb2LnmCqZhrMWK q+5XDnb2JQ3nlqH5FQ6gJhXDh4Dwc3XP0IIoYFQg= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 082036FC86 for ; Wed, 24 Mar 2021 19:03:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 082036FC86 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lP5yG-0006f7-3V; Wed, 24 Mar 2021 19:03:00 +0300 To: Igor Munkin Cc: Alexander Turenko , tarantool-patches@dev.tarantool.org References: <7f444b92bacefea0e3a0b2d2846737d9791626ea.1614256802.git.imun@tarantool.org> <0a7f111d-7119-bd2d-020d-1938edeb973e@tarantool.org> <20210311121342.GV9042@tarantool.org> Message-ID: Date: Wed, 24 Mar 2021 19:02:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210311121342.GV9042@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9064ADF4728AA0EE9F947F818E4E5150DE0627C7B5DF808F3182A05F538085040DAC490733272115F7432A60A744CF0482875B44DEE42A9FE314F1B6D59B834B1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77633BACAB33B9508C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7B7733D0215A2F71AEA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC76645339ADD1E8AE8E08927B65CD73EA96EFF3BB87BFA5C38DDB389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D52CD31C43BF465FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E34F43C7A68FF626056395957E7521B51C29E9CE733340B9D5F68655334FD4449CB9ECD01F8117BC8BEE2021AF6380DFAD19449624AB7ADAF3735872C767BF85DA29E625A9149C048EED1AC325EA934333D28A6D463EDFD0DBB4AD6D5ED66289B524E70A05D1297E1BB35872C767BF85DA227C277FBC8AE2E8B08A41ED4D9ABB1BC75ECD9A6C639B01B4E70A05D1297E1BBC6867C52282FAC85D9B7C4F32B44FF57285124B2A10EEC6C00306258E7E6ABB4E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A50E10F551D4A05A27213572ACC84B90785C0114DC7DDACF9AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3473688ED311681BF00EE54873BA4E5AD0B0693700628A868B82ACF7D125311896147DD4CA0863C72A1D7E09C32AA3244CCD0302AB95185AD8982384123094F188F2F5F14F68F1805BFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojjqzNotmU+gf2flinFxdrrA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822F3FC2763ABCBC75B3E6879385749EEC2DD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] tools: implement toolchain for crash artefacts X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, thanks for changes! Generally LGTM with two notes inline. On 11.03.2021 15:13, Igor Munkin wrote: > Sergey, > > Thanks for your review! > > On 03.03.21, Sergey Bronnikov wrote: >> 2. I propose to show files included to the report and the end of creation. > Well, I believe I didn't understand you right before (this list is > included to the archive). Anyway, now I added the list also to the > message at the end. You got it right. 1. in a private conversation we decided to remove mention of public resource in a message "http://transfer.sh". >  - Manual usage. User can simply pack all necessary artefacts by running the >    following command. >    $ /path/to/${TOOL} -c ./core -d /tmp > >  - Automatic usage. If user faces the failures often, one can set this script >    as a pipe reciever in kernel.core_pattern syntax. >    # sysctl -w kernel.core_pattern="|/absolute/path/to/${TOOL} -d /var/core -p %p -t %t" 2. it would be more convenient to set real path to tarabrt.sh in a usage, see patch below --- a/tools/tarabrt.sh +++ b/tools/tarabrt.sh @@ -2,6 +2,8 @@  set -eu  TOOL=$(basename "$0") +#TOOLPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )" +TOOLPATH=$(realpath -s $0)  HELP=$(cat <