From: Oleg Babin <olegrok@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/3] lua/cfg: drop redundant variable
Date: Mon, 8 Jun 2020 18:31:06 +0300 [thread overview]
Message-ID: <ecc1a7ac-a602-4f55-2fa5-30b4246c80be@tarantool.org> (raw)
In-Reply-To: <20200608104450.157253-3-gorcunov@gmail.com>
Thanks for your patch. LGTM.
On 08/06/2020 13:44, Cyrill Gorcunov wrote:
> No need for variable v, we use module_cfg itself.
>
> Part-of #689
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> src/box/lua/load_cfg.lua | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/box/lua/load_cfg.lua b/src/box/lua/load_cfg.lua
> index 7a77b93f5..7dc40a47f 100644
> --- a/src/box/lua/load_cfg.lua
> +++ b/src/box/lua/load_cfg.lua
> @@ -494,7 +494,7 @@ local function apply_default_cfg(cfg, default_cfg, module_cfg)
> apply_default_cfg(cfg[k], v)
> end
> end
> - for k, v in pairs(module_cfg) do
> + for k in pairs(module_cfg) do
> if cfg[k] == nil then
> cfg[k] = module_cfg[k].cfg_get(k)
> end
>
next prev parent reply other threads:[~2020-06-08 15:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 10:44 [Tarantool-patches] [PATCH 0/3] lua/cfg: drop unused code and extend test Cyrill Gorcunov
2020-06-08 10:44 ` [Tarantool-patches] [PATCH 1/3] lua/cfg: drop unused log methods Cyrill Gorcunov
2020-06-08 15:29 ` Oleg Babin
2020-06-08 15:33 ` Cyrill Gorcunov
2020-06-08 15:37 ` Oleg Babin
2020-06-08 10:44 ` [Tarantool-patches] [PATCH 2/3] lua/cfg: drop redundant variable Cyrill Gorcunov
2020-06-08 15:31 ` Oleg Babin [this message]
2020-06-08 10:44 ` [Tarantool-patches] [PATCH 3/3] test: app-tap/logger -- test symbolic loglevels Cyrill Gorcunov
2020-06-08 15:31 ` Oleg Babin
2020-06-09 8:26 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecc1a7ac-a602-4f55-2fa5-30b4246c80be@tarantool.org \
--to=olegrok@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/3] lua/cfg: drop redundant variable' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox