Re: [Tarantool-patches] [PATCH 1/2] box: rework local_recovery to use async txn_commit

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hi! Thanks for the patch!

> diff --git a/src/box/box.cc b/src/box/box.cc
> index f80d6f8e6..0fe7625fb 100644
> --- a/src/box/box.cc
> +++ b/src/box/box.cc
> @@ -222,6 +222,12 @@ box_process_rw(struct request *request, struct space *space,
>                  */
>                 if (is_local_recovery) {
>                         res = txn_commit_async(txn);
> +                       /*
> +                        * Hack: remove the unnecessary trigger.
> +                        * I don't know of a better place to do
> +                        * it.
> +                        */

Why is it necessary to remove it?

> + trigger_clear(&txn->on_write_failure);
>                 } else {
>                         res = txn_commit(txn);
>                 }