From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Prevent CSE of a REF_BASE operand across IR_RETF.
Date: Thu, 30 Nov 2023 11:53:59 +0300 [thread overview]
Message-ID: <ec1a7ea3-0e7f-4a86-9326-eb96e281829c@tarantool.org> (raw)
In-Reply-To: <ZWg7DxsNn-VTxtSF@root>
Thanks! LGTM as I said before.
On 11/30/23 10:34, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> I've fixed your comment regarding test comment and force-pushed the
> branch.
>
> On 29.11.23, Sergey Bronnikov wrote:
>> Hello, Sergey
>>
>> thanks for the patch!
>>
>> LGTM with a three minor comments below
>>
>> On 11/28/23 15:21, Sergey Kaplun wrote:
>>
<snipped>
next prev parent reply other threads:[~2023-11-30 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 12:21 Sergey Kaplun via Tarantool-patches
2023-11-29 14:26 ` Sergey Bronnikov via Tarantool-patches
2023-11-30 7:34 ` Sergey Kaplun via Tarantool-patches
2023-11-30 8:53 ` Sergey Bronnikov via Tarantool-patches [this message]
2023-11-30 17:59 ` Maxim Kokryashkin via Tarantool-patches
2024-01-10 8:51 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec1a7ea3-0e7f-4a86-9326-eb96e281829c@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] Prevent CSE of a REF_BASE operand across IR_RETF.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox