From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [PATCH 6/8] vinyl: zap vy_worker_pool::idle_worker_count Date: Tue, 4 Sep 2018 20:23:49 +0300 [thread overview] Message-ID: <ebea18583f76d4e350853dce2e0d83ae5c4eb30c.1536080993.git.vdavydov.dev@gmail.com> (raw) In-Reply-To: <cover.1536080993.git.vdavydov.dev@gmail.com> In-Reply-To: <cover.1536080993.git.vdavydov.dev@gmail.com> It is not used anywhere anymore. --- src/box/vy_scheduler.c | 6 ------ src/box/vy_scheduler.h | 2 -- 2 files changed, 8 deletions(-) diff --git a/src/box/vy_scheduler.c b/src/box/vy_scheduler.c index dbc3ca69..4f57c0a0 100644 --- a/src/box/vy_scheduler.c +++ b/src/box/vy_scheduler.c @@ -340,7 +340,6 @@ vy_worker_pool_start(struct vy_worker_pool *pool) { assert(pool->workers == NULL); - pool->idle_worker_count = pool->size; pool->workers = calloc(pool->size, sizeof(*pool->workers)); if (pool->workers == NULL) panic("failed to allocate vinyl worker pool"); @@ -385,7 +384,6 @@ vy_worker_pool_create(struct vy_worker_pool *pool, const char *name, int size) pool->size = size; pool->workers = NULL; stailq_create(&pool->idle_workers); - pool->idle_worker_count = 0; } static void @@ -403,8 +401,6 @@ vy_worker_pool_get(struct vy_worker_pool *pool) { struct vy_worker *worker = NULL; if (!stailq_empty(&pool->idle_workers)) { - assert(pool->idle_worker_count > 0); - pool->idle_worker_count--; worker = stailq_shift_entry(&pool->idle_workers, struct vy_worker, in_idle); assert(worker->pool == pool); @@ -420,8 +416,6 @@ static void vy_worker_pool_put(struct vy_worker *worker) { struct vy_worker_pool *pool = worker->pool; - assert(pool->idle_worker_count < pool->size); - pool->idle_worker_count++; stailq_add_entry(&pool->idle_workers, worker, in_idle); } diff --git a/src/box/vy_scheduler.h b/src/box/vy_scheduler.h index 7014f953..841d5a53 100644 --- a/src/box/vy_scheduler.h +++ b/src/box/vy_scheduler.h @@ -65,8 +65,6 @@ struct vy_worker_pool { struct vy_worker *workers; /** List of workers that are currently idle. */ struct stailq idle_workers; - /** Length of @idle_workers list. */ - int idle_worker_count; }; struct vy_scheduler { -- 2.11.0
next prev parent reply other threads:[~2018-09-04 17:23 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-02 20:18 [PATCH 0/7] vinyl: improve stats for throttling Vladimir Davydov 2018-09-02 20:18 ` [PATCH 1/7] vinyl: fix accounting of secondary index cache statements Vladimir Davydov 2018-09-02 22:26 ` [tarantool-patches] " Konstantin Osipov 2018-09-02 20:18 ` [PATCH 2/7] vinyl: add global memory stats Vladimir Davydov 2018-09-02 22:27 ` [tarantool-patches] " Konstantin Osipov 2018-09-02 22:27 ` Konstantin Osipov 2018-09-03 8:10 ` Vladimir Davydov 2018-09-02 20:18 ` [PATCH 3/7] vinyl: add global disk stats Vladimir Davydov 2018-09-02 22:30 ` [tarantool-patches] " Konstantin Osipov 2018-09-02 20:18 ` [PATCH 4/7] vinyl: fix force compaction logic Vladimir Davydov 2018-09-02 20:18 ` [PATCH 5/7] vinyl: update compact priority usual way on range split/coalesce Vladimir Davydov 2018-09-02 20:18 ` [PATCH 6/7] vinyl: keep track of compaction queue length and debt Vladimir Davydov 2018-09-02 20:19 ` [PATCH 7/7] vinyl: keep track of disk idle time Vladimir Davydov 2018-09-04 11:54 ` Vladimir Davydov 2018-09-04 17:23 ` Vladimir Davydov 2018-09-04 17:23 ` [PATCH 1/8] vinyl: add helper to check whether dump is in progress Vladimir Davydov 2018-09-06 7:33 ` Konstantin Osipov 2018-09-04 17:23 ` [PATCH 2/8] vinyl: don't use mempool for allocating background tasks Vladimir Davydov 2018-09-06 7:33 ` Konstantin Osipov 2018-09-04 17:23 ` [PATCH 3/8] vinyl: factor out worker pool from scheduler struct Vladimir Davydov 2018-09-06 7:34 ` Konstantin Osipov 2018-09-04 17:23 ` [PATCH 4/8] vinyl: move worker allocation closer to task creation Vladimir Davydov 2018-09-06 7:35 ` Konstantin Osipov 2018-09-04 17:23 ` [PATCH 5/8] vinyl: use separate thread pools for dump and compaction tasks Vladimir Davydov 2018-09-06 7:37 ` Konstantin Osipov 2018-09-06 9:48 ` Vladimir Davydov 2018-09-06 10:32 ` Konstantin Osipov 2018-09-04 17:23 ` Vladimir Davydov [this message] 2018-09-06 7:38 ` [PATCH 6/8] vinyl: zap vy_worker_pool::idle_worker_count Konstantin Osipov 2018-09-04 17:23 ` [PATCH 7/8] vinyl: don't start scheduler fiber until local recovery is complete Vladimir Davydov 2018-09-06 7:39 ` Konstantin Osipov 2018-09-04 17:23 ` [PATCH 8/8] vinyl: keep track of thread pool idle ratio Vladimir Davydov 2018-09-06 7:49 ` Konstantin Osipov 2018-09-06 8:18 ` Vladimir Davydov 2018-09-06 10:26 ` Konstantin Osipov 2018-09-06 10:52 ` Vladimir Davydov 2018-09-06 10:57 ` Konstantin Osipov 2018-09-06 11:59 ` Vladimir Davydov 2018-09-09 11:41 ` [PATCH 0/7] vinyl: improve stats for throttling Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ebea18583f76d4e350853dce2e0d83ae5c4eb30c.1536080993.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH 6/8] vinyl: zap vy_worker_pool::idle_worker_count' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox