Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Cc: alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] build: install curl headers
Date: Thu, 24 Dec 2020 14:28:40 +0300	[thread overview]
Message-ID: <eba0c83a-a3d9-48f6-8eef-ee5427bbc936@tarantool.org> (raw)
In-Reply-To: <20201222161725.37048-1-roman.habibov@tarantool.org>

Hi,

thanks for the patch!

On 22.12.2020 19:17, Roman Khabibov via Tarantool-patches wrote:
> Ship curl headers to system path include/tarantool.

1. could you add issue number to the commit message?

> ---
>
> Issue: https://github.com/tarantool/smtp/issues/24
2. looks like this patch is only a part of a task, is it so?
> Bracnh: https://github.com/tarantool/tarantool/tree/romanhabibov/curl-headers
>
>   cmake/BuildLibCURL.cmake | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/cmake/BuildLibCURL.cmake b/cmake/BuildLibCURL.cmake
> index 39a1d62fd..8fd063454 100644
> --- a/cmake/BuildLibCURL.cmake
> +++ b/cmake/BuildLibCURL.cmake
> @@ -178,6 +178,11 @@ macro(curl_build)
>           set(CURL_LIBRARIES ${CURL_LIBRARIES} rt)
>       endif()
>   
> +    # Install headers.
> +    install(DIRECTORY "${CURL_INCLUDE_DIRS}/curl"
> +            DESTINATION ${MODULE_FULL_INCLUDEDIR}
> +            FILES_MATCHING PATTERN "*.h")
> +
>       unset(FOUND_ZLIB_ROOT_DIR)
>       unset(FOUND_OPENSSL_ROOT_DIR)
>       unset(LIBCURL_INSTALL_DIR)


I build tarantool with custom PREFIX dirs:

cmake --install /home/s.bronnikov/work/tarantool_prefix_path \

-DCMAKE_PREFIX_PATH=/home/s.bronnikov/work/tarantool_prefix_path \

-DCMAKE_INSTALL_PREFIX=/home/s.bronnikov/work/tarantool_prefix_path ..

and it seems set of installed headers are the same as in libcurl-devel 
package:

[s.bronnikov@tarantool-core-dev-mcs1 build]$ find 
/home/s.bronnikov/work/tarantool_prefix_path/include/tarantool/curl 
-name "*.h"
/home/s.bronnikov/work/tarantool_prefix_path/include/tarantool/curl/mprintf.h
/home/s.bronnikov/work/tarantool_prefix_path/include/tarantool/curl/system.h
/home/s.bronnikov/work/tarantool_prefix_path/include/tarantool/curl/multi.h
/home/s.bronnikov/work/tarantool_prefix_path/include/tarantool/curl/curl.h
/home/s.bronnikov/work/tarantool_prefix_path/include/tarantool/curl/urlapi.h
/home/s.bronnikov/work/tarantool_prefix_path/include/tarantool/curl/stdcheaders.h
/home/s.bronnikov/work/tarantool_prefix_path/include/tarantool/curl/curlver.h
/home/s.bronnikov/work/tarantool_prefix_path/include/tarantool/curl/typecheck-gcc.h
/home/s.bronnikov/work/tarantool_prefix_path/include/tarantool/curl/easy.h

[s.bronnikov@tarantool-core-dev-mcs1 build]$ rpm -ql 
libcurl-devel.x86_64 | grep "/usr/include/"
/usr/include/curl
/usr/include/curl/curl.h
/usr/include/curl/curlver.h
/usr/include/curl/easy.h
/usr/include/curl/mprintf.h
/usr/include/curl/multi.h
/usr/include/curl/stdcheaders.h
/usr/include/curl/system.h
/usr/include/curl/typecheck-gcc.h
/usr/include/curl/urlapi.h

  reply	other threads:[~2020-12-24 11:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22 16:17 Roman Khabibov
2020-12-24 11:28 ` Sergey Bronnikov [this message]
2021-02-26 22:42   ` Alexander Turenko via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eba0c83a-a3d9-48f6-8eef-ee5427bbc936@tarantool.org \
    --to=sergeyb@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=roman.habibov@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] build: install curl headers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox