From: Alexander Turenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] build: install curl headers
Date: Sat, 27 Feb 2021 01:42:13 +0300 [thread overview]
Message-ID: <20210226224213.bbb7ejadhcr7f46u@tkn_work_nb> (raw)
In-Reply-To: <eba0c83a-a3d9-48f6-8eef-ee5427bbc936@tarantool.org>
On Thu, Dec 24, 2020 at 02:28:40PM +0300, Sergey Bronnikov via Tarantool-patches wrote:
> Hi,
>
> thanks for the patch!
>
> On 22.12.2020 19:17, Roman Khabibov via Tarantool-patches wrote:
> > Ship curl headers to system path include/tarantool.
>
> 1. could you add issue number to the commit message?
It is part of https://github.com/tarantool/smtp/issues/24
However I don't see SMTP enabling, that's strange. Roman?
>
> > ---
> >
> > Issue: https://github.com/tarantool/smtp/issues/24
> 2. looks like this patch is only a part of a task, is it so?
Yep.
> I build tarantool with custom PREFIX dirs:
>
> cmake --install /home/s.bronnikov/work/tarantool_prefix_path \
>
> -DCMAKE_PREFIX_PATH=/home/s.bronnikov/work/tarantool_prefix_path \
>
> -DCMAKE_INSTALL_PREFIX=/home/s.bronnikov/work/tarantool_prefix_path ..
>
> and it seems set of installed headers are the same as in libcurl-devel
> package:
That's expected result. We want to ship curl headers in
'/usr/include/tarantool/curl/*.h'.
prev parent reply other threads:[~2021-02-26 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 16:17 Roman Khabibov
2020-12-24 11:28 ` Sergey Bronnikov
2021-02-26 22:42 ` Alexander Turenko via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226224213.bbb7ejadhcr7f46u@tkn_work_nb \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] build: install curl headers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox