From: Oleg Babin <olegrok@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org,
alexander.turenko@tarantool.org
Cc: Oleg Babin <babinoleg@mail.ru>
Subject: Re: [Tarantool-patches] [PATCH] lua: handle uri.format empty input properly
Date: Sat, 15 Feb 2020 20:37:55 +0300 [thread overview]
Message-ID: <eafc6587-2b2c-f5e1-65f6-db8da4183a7f@tarantool.org> (raw)
In-Reply-To: <55bad826-7af6-cf0b-b917-743c07d94d62@tarantool.org>
Hi! Thanks for your review!
On 15/02/2020 19:15, Vladislav Shpilevoy wrote:
>> However situation then uri.format output is zero-length
>
> then -> when.
>
Fixed. Thanks. I've updated commit message.
> Lets add a dot to the end of the sentence, and elaborate
> a little about why do we call static_alloc() before this
> test and fill it with something. You and me are in the context,
> but for someone, who doesn't know the issue and looks at this
> test it may look strange.
Yes. I've added following comment:
-- As static allocator is also used in several places
-- we should properly handle situation when output
-- is zero-length string.
-- Here we allocate the whole buffer,
-- fill it with some "junk" bytes and
-- check that result doesn't contain any of them.
I've force-pushed updates to my branch:
https://github.com/tarantool/tarantool/tree/olegrok/4779-uri-format-junk-output
next prev parent reply other threads:[~2020-02-15 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 9:31 olegrok
2020-02-15 16:15 ` Vladislav Shpilevoy
2020-02-15 17:37 ` Oleg Babin [this message]
2020-02-16 15:11 ` Vladislav Shpilevoy
2020-02-18 5:23 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eafc6587-2b2c-f5e1-65f6-db8da4183a7f@tarantool.org \
--to=olegrok@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=babinoleg@mail.ru \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] lua: handle uri.format empty input properly' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox