From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] Only emit proper parent references in snapshot replay.
Date: Thu, 8 Feb 2024 17:12:28 +0300 [thread overview]
Message-ID: <eaf97abd-ca10-441b-a59c-193efc75d7f2@tarantool.org> (raw)
In-Reply-To: <ZcIa061Yh0urGDef@root>
Hi, Sergey
(spoiler - LGTM)
On 2/6/24 14:41, Sergey Kaplun wrote:
> On 06.02.24, Sergey Bronnikov wrote:
>> On 2/6/24 13:07, Sergey Kaplun wrote:
>>> Hi, Sergey!
>>> Thanks for the review!
>>>
>>> On 06.02.24, Sergey Bronnikov wrote:
>>>> Hi, Sergey
>>>>
>>>> thanks for the patch! test is passed with reverted patch.
> Do you revert only this patch or the previous one too (or run just on
> the cloned master)?
> Because without the previous patch (1/2), the repro doesn't work.
>
> I've tried this flags locally and test is failed as expeced for GC64 and
> non-GC64 builds.
>
>
Seems it was a problem on my side (probably forgot to stash patch after
`git reset`).
The problem is reproduced by test, luajit is crashed with segmentation
fault.
Patch LGTM, thanks!
<snipped>
next prev parent reply other threads:[~2024-02-08 14:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 14:11 [Tarantool-patches] [PATCH luajit 0/2] Fix unsinking TNEW with huge asize Sergey Kaplun via Tarantool-patches
2024-01-24 14:11 ` [Tarantool-patches] [PATCH luajit 1/2] Optimize table.new() with constant args to (sinkable) IR_TNEW Sergey Kaplun via Tarantool-patches
2024-01-31 9:20 ` Maxim Kokryashkin via Tarantool-patches
2024-01-31 9:36 ` Sergey Kaplun via Tarantool-patches
2024-02-05 14:39 ` Sergey Bronnikov via Tarantool-patches
2024-01-24 14:11 ` [Tarantool-patches] [PATCH luajit 2/2] Only emit proper parent references in snapshot replay Sergey Kaplun via Tarantool-patches
2024-01-31 9:29 ` Maxim Kokryashkin via Tarantool-patches
2024-02-06 9:46 ` Sergey Bronnikov via Tarantool-patches
2024-02-06 10:07 ` Sergey Kaplun via Tarantool-patches
2024-02-06 11:07 ` Sergey Bronnikov via Tarantool-patches
2024-02-06 11:41 ` Sergey Kaplun via Tarantool-patches
2024-02-08 14:12 ` Sergey Bronnikov via Tarantool-patches [this message]
2024-02-15 13:45 ` [Tarantool-patches] [PATCH luajit 0/2] Fix unsinking TNEW with huge asize Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaf97abd-ca10-441b-a59c-193efc75d7f2@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 2/2] Only emit proper parent references in snapshot replay.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox