[Tarantool-patches] [PATCH] Fix queue test preparing

[Tarantool-patches] [PATCH] Fix queue test preparing

[Leonid Vasiliev]

Add redirect procesing and check of a commands exit code.

---
 test.sh | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/test.sh b/test.sh
index 3fca125..32f7567 100755
--- a/test.sh
+++ b/test.sh
@@ -1,15 +1,17 @@
 #!/bin/bash
 
+set -euo pipefail
+
 VERSION=${VERSION:-2_2}
 
-curl https://packagecloud.io/tarantool/${VERSION}/gpgkey | sudo apt-key add -
+curl -sfL https://packagecloud.io/tarantool/${VERSION}/gpgkey | sudo apt-key add -
 release=`lsb_release -c -s`
 
 sudo apt-get install -y apt-transport-https
 
 sudo tee /etc/apt/sources.list.d/tarantool_${VERSION}.list <<- EOF
-deb https://packagecloud.io/tarantool/${VERSION}/ubuntu/ $release main
-deb-src https://packagecloud.io/tarantool/${VERSION}/ubuntu/ $release main
+deb https://packagecloud.io/tarantool/${VERSION}/ubuntu/ ${release} main
+deb-src https://packagecloud.io/tarantool/${VERSION}/ubuntu/ ${release} main
 EOF
 
 sudo apt-get update > /dev/null
-- 
2.17.1

Re: [Tarantool-patches] [PATCH] Fix queue test preparing

[Leonid Vasiliev]

https://github.com/tarantool/queue/tree/lvasiliev/gh-noticket-fix-redirect-case

On 12/6/19 8:36 PM, Leonid Vasiliev wrote:
> Add redirect procesing and check of a commands exit code.
> 
> ---
>   test.sh | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/test.sh b/test.sh
> index 3fca125..32f7567 100755
> --- a/test.sh
> +++ b/test.sh
> @@ -1,15 +1,17 @@
>   #!/bin/bash
>   
> +set -euo pipefail
> +
>   VERSION=${VERSION:-2_2}
>   
> -curl https://packagecloud.io/tarantool/${VERSION}/gpgkey | sudo apt-key add -
> +curl -sfL https://packagecloud.io/tarantool/${VERSION}/gpgkey | sudo apt-key add -
>   release=`lsb_release -c -s`
>   
>   sudo apt-get install -y apt-transport-https
>   
>   sudo tee /etc/apt/sources.list.d/tarantool_${VERSION}.list <<- EOF
> -deb https://packagecloud.io/tarantool/${VERSION}/ubuntu/ $release main
> -deb-src https://packagecloud.io/tarantool/${VERSION}/ubuntu/ $release main
> +deb https://packagecloud.io/tarantool/${VERSION}/ubuntu/ ${release} main
> +deb-src https://packagecloud.io/tarantool/${VERSION}/ubuntu/ ${release} main
>   EOF
>   
>   sudo apt-get update > /dev/null
> 

Re: [Tarantool-patches] [PATCH] Fix queue test preparing

[Alexander Turenko]

Expanded the commit message:

 | travis-ci: handle packagecloud's HTTP redirects
 |
 | Added curl options:
 |
 | * -L (--location) to follow Location header value from 3XX responses,
 |   because packagecloud.io redirects a GPG key request to a CDN.
 | * -s (--silent) to don't show a progress meter.
 | * -f (--fail) to fail the command at non 2XX HTTP responses. It'll fail
 |   `curl | <...>` command pipeline, since `set -o pipefail` is now
 |   enabled.
 |
 | Aside of that, fail test.sh script (and so a CI job) if something inside
 | the script fails (`set -e`) and catch mistakes from using uninitialized
 | bash variables (`set -u`) inside the script.

And pushed.

Thanks!

WBR, Alexander Turenko.

On Fri, Dec 06, 2019 at 10:18:55PM +0300, Leonid Vasiliev wrote:
> https://github.com/tarantool/queue/tree/lvasiliev/gh-noticket-fix-redirect-case
> 
> On 12/6/19 8:36 PM, Leonid Vasiliev wrote:
> > Add redirect procesing and check of a commands exit code.
> > 
> > ---
> >   test.sh | 8 +++++---
> >   1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/test.sh b/test.sh
> > index 3fca125..32f7567 100755
> > --- a/test.sh
> > +++ b/test.sh
> > @@ -1,15 +1,17 @@
> >   #!/bin/bash
> > +set -euo pipefail
> > +
> >   VERSION=${VERSION:-2_2}
> > -curl https://packagecloud.io/tarantool/${VERSION}/gpgkey | sudo apt-key add -
> > +curl -sfL https://packagecloud.io/tarantool/${VERSION}/gpgkey | sudo apt-key add -
> >   release=`lsb_release -c -s`
> >   sudo apt-get install -y apt-transport-https
> >   sudo tee /etc/apt/sources.list.d/tarantool_${VERSION}.list <<- EOF
> > -deb https://packagecloud.io/tarantool/${VERSION}/ubuntu/ $release main
> > -deb-src https://packagecloud.io/tarantool/${VERSION}/ubuntu/ $release main
> > +deb https://packagecloud.io/tarantool/${VERSION}/ubuntu/ ${release} main
> > +deb-src https://packagecloud.io/tarantool/${VERSION}/ubuntu/ ${release} main
> >   EOF
> >   sudo apt-get update > /dev/null
> >