Re: [Tarantool-patches] [PATCH 4/7] box/console: rename luaL_yaml_default to serializer_yaml

[Oleg Babin <olegrok@tarantool.org>]

Igor, thanks for explanation! Yes, then my comment is not relevant.

On 19/05/2020 00:17, Igor Munkin wrote:
> Oleg,
> 
> On 18.05.20, Oleg Babin wrote:
>> Hi! I'm not sure that we really should do that. Functions with LuaL
>> prefix is a part of Lua code convention AFAIK.
>> (https://www.lua.org/manual/5.1/manual.html#4)
> 
> No, it doesn't relate to Lua code convention (at least to the one you've
> mentioned). luaL_ is just a custom prefix for functions declared/defined
> in lauxlib.h header, which is a part of Lua public API.
> 
> | All functions from the auxiliary library are defined in header file
> | lauxlib.h and have a prefix luaL_.
> 
> However this prefix is also used for auxiliary functions provided by
> Tarantool (e.g luaL_pushcdata). This *might* be an argument for
> convention saving but it's definitely a weak one for these changes. I
> see no problems with the renaming Cyrill made within this patch, since
> it just affects the name of the static global variable. Please also
> consider the issue[1] that closely relates to the subj.
> 
>>
> 
> <snipped>
> 
> [1]: https://github.com/tarantool/tarantool/issues/4577
>