From: Oleg Babin <olegrok@tarantool.org> To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org> Cc: Alexander Turenko <alexander.turenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 07/10] lua/log: use log module settings inside box.cfg Date: Mon, 25 May 2020 18:43:27 +0300 [thread overview] Message-ID: <e9afeae0-19d5-9387-e0a1-3a05a69b0a14@tarantool.org> (raw) In-Reply-To: <20200525121715.21216-8-gorcunov@gmail.com> Hi! Thanks for your patch! See my comments below. On 25/05/2020 15:17, Cyrill Gorcunov wrote: > > local function log_pid() > @@ -197,6 +215,18 @@ return setmetatable({ > pid = log_pid; > level = log_level; > log_format = log_format; > + cfg = cfg, > + -- > + -- Internal API to box module, not for users, > + -- names can be changed. > + box_api = { > + set_log_level = function() > + log_level(box.cfg.log_level) > + end, > + set_log_format = function() > + log_format(box.cfg.log_format) > + end, > + } > }, { > __index = compat_v16; > }) > I think we should hide internal functions from user as it is done e.g. in fiber module: https://github.com/tarantool/tarantool/blob/master/src/lua/fiber.lua#L89 Also I thinks we shouldn't expose some of functions: ```lua tarantool> log = require('log') --- ... tarantool> log --- - level: 'function: 0x010c087cd8' log_format: 'function: 0x010c069d08' info: 'function: 0x010c0a3d18' pid: 'function: 0x010c09db10' error: 'function: 0x010c042410' warn: 'function: 0x010c0a2048' box_api: cfg_update: 'function: 0x010c09e248' set_log_level: 'function: 0x010c047818' set_log_format: 'function: 0x010c070f78' cfg: log_level: 5 log_format: plain debug: 'function: 0x010c0a6130' init: 'function: 0x010c0762a0' rotate: 'function: 0x010c08b7d0' verbose: 'function: 0x010c0a4758' ... tarantool> log.logger_pid() -- shouldn't be exposed if deprecated logger_pid() is deprecated, please use pid() instead --- - 0 ... ``` And IMO it will be great if an interface that will be similar to box.cfg/json.cfg/yaml.cfg... - log.cfg({...}). For that we can add __call metamethod for cfg table.
next prev parent reply other threads:[~2020-05-25 15:43 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-25 12:17 [Tarantool-patches] [PATCH 00/10] lua/log: add an ability to setup logger without box.cfg{} Cyrill Gorcunov 2020-05-25 12:17 ` [Tarantool-patches] [PATCH 01/10] core/say: drop redundant declarations Cyrill Gorcunov 2020-05-25 12:17 ` [Tarantool-patches] [PATCH 02/10] core/say: drop vsay declaration Cyrill Gorcunov 2020-05-25 12:17 ` [Tarantool-patches] [PATCH 03/10] core/say: do not reconfig early set up logger Cyrill Gorcunov 2020-05-25 12:17 ` [Tarantool-patches] [PATCH 04/10] lua/log: declare say_logger_init and say_logger_initialized Cyrill Gorcunov 2020-05-25 12:17 ` [Tarantool-patches] [PATCH 05/10] lua/log: put string constants to map Cyrill Gorcunov 2020-05-25 12:17 ` [Tarantool-patches] [PATCH 06/10] lua/log: do not allow to set json for boot logger Cyrill Gorcunov 2020-05-25 12:17 ` [Tarantool-patches] [PATCH 07/10] lua/log: use log module settings inside box.cfg Cyrill Gorcunov 2020-05-25 15:43 ` Oleg Babin [this message] 2020-05-25 15:49 ` Cyrill Gorcunov 2020-05-25 12:17 ` [Tarantool-patches] [PATCH 08/10] lua/log: allow to configure logging without a box Cyrill Gorcunov 2020-05-25 12:17 ` [Tarantool-patches] [PATCH 09/10] lua/log: update log status via box.cfg call Cyrill Gorcunov 2020-05-25 12:17 ` [Tarantool-patches] [PATCH 10/10] test: use direct log module Cyrill Gorcunov 2020-05-25 12:18 ` [Tarantool-patches] [PATCH 00/10] lua/log: add an ability to setup logger without box.cfg{} Cyrill Gorcunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e9afeae0-19d5-9387-e0a1-3a05a69b0a14@tarantool.org \ --to=olegrok@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 07/10] lua/log: use log module settings inside box.cfg' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox