[tarantool-patches] [PATCH 1/1] wal: deprecate wal_max_rows in favour of wal_max_size

[tarantool-patches] [PATCH 1/1] wal: deprecate wal_max_rows in favour of wal_max_size

[Vladislav Shpilevoy]

wal_max_rows does not allow to properly limit size of WAL logs.
A user would need to estimate size of each WAL row to do that.
Now WAL supports option wal_max_size allowing to limit WAL size
much more precise.

Part of #3762
---
Note: Based on branch 1.10. It should be pushed to 1.10 and cherry-picked to
all > 1.10 and < master.

Issue: https://github.com/tarantool/tarantool/issues/3762
Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4282-box-cfg-rs-uuid

 src/box/lua/load_cfg.lua | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/box/lua/load_cfg.lua b/src/box/lua/load_cfg.lua
index 77f57eb05..432a3374b 100644
--- a/src/box/lua/load_cfg.lua
+++ b/src/box/lua/load_cfg.lua
@@ -291,6 +291,7 @@ local translate_cfg = {
     panic_on_snap_error = {'force_recovery', function (p) return not p end},
     panic_on_wal_error = {'force_recovery', function (p) return not p end},
     replication_source = {'replication'},
+    wal_max_rows = {'wal_max_size'},
 }
 
 -- Upgrade old config
-- 
2.20.1 (Apple Git-117)

[tarantool-patches] Re: [PATCH 1/1] wal: deprecate wal_max_rows in favour of wal_max_size

[Vladislav Shpilevoy]

Sorry, ignore it, please.

On 07/09/2019 15:51, Vladislav Shpilevoy wrote:
> wal_max_rows does not allow to properly limit size of WAL logs.
> A user would need to estimate size of each WAL row to do that.
> Now WAL supports option wal_max_size allowing to limit WAL size
> much more precise.
> 
> Part of #3762
> ---
> Note: Based on branch 1.10. It should be pushed to 1.10 and cherry-picked to
> all > 1.10 and < master.
> 
> Issue: https://github.com/tarantool/tarantool/issues/3762
> Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4282-box-cfg-rs-uuid
> 
>  src/box/lua/load_cfg.lua | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/box/lua/load_cfg.lua b/src/box/lua/load_cfg.lua
> index 77f57eb05..432a3374b 100644
> --- a/src/box/lua/load_cfg.lua
> +++ b/src/box/lua/load_cfg.lua
> @@ -291,6 +291,7 @@ local translate_cfg = {
>      panic_on_snap_error = {'force_recovery', function (p) return not p end},
>      panic_on_wal_error = {'force_recovery', function (p) return not p end},
>      replication_source = {'replication'},
> +    wal_max_rows = {'wal_max_size'},
>  }
>  
>  -- Upgrade old config
>